fix: Do not call of caching service during routing to check sticky session if not needed#4549
Open
pavel-jares-bcm wants to merge 4 commits intov3.x.xfrom
Open
fix: Do not call of caching service during routing to check sticky session if not needed#4549pavel-jares-bcm wants to merge 4 commits intov3.x.xfrom
pavel-jares-bcm wants to merge 4 commits intov3.x.xfrom
Conversation
github-project-automation
bot
moved this to New
in API Mediation Layer Backlog Management
taban03
reviewed
Apr 10, 2026
|
|
||
| boolean stickySession = lbTypeIsAuthentication(serviceInstances.iterator().next()); | ||
| if (!stickySession) { | ||
| // service does not support sticky session by userId, just return |
Contributor
There was a problem hiding this comment.
should we log some message in debug also for this condition?
Contributor
Author
There was a problem hiding this comment.
added one for each branch
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
taban03
approved these changes
Apr 14, 2026
Contributor
|
Please provide a description in the PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is the class DeterministicLoadBalancer. This class is reposible for deterministic routing of request. It uses header X-InstanceId or last used used server to implement sticky session.
The issue is in the order of taken actions to process the request. If the request contains a token (the user could be detected) it always call caching service, even the value is not used there.
The impact:
more I/O and performance degradation for authenticated request
it could failed when Caching service is down (even the call is not needed)
Linked to #4510
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline