Skip to content

chore: Add turboFilter to enhance the infinispan debug message#4567

Open
taban03 wants to merge 5 commits intov3.x.xfrom
reboot/enhance_infinispan_message
Open

chore: Add turboFilter to enhance the infinispan debug message#4567
taban03 wants to merge 5 commits intov3.x.xfrom
reboot/enhance_infinispan_message

Conversation

@taban03
Copy link
Copy Markdown
Contributor

@taban03 taban03 commented Apr 14, 2026

Description

Add Logback TurboFilter to enhance the infinispan debug message that occurs when Infinispan fails to open or access a cache segment file (index) in org.infinispan.persistence.sifs.FileProvider. The filter will intercept the message, and enhance it by appending a new Zowe message code ZWECS137W that will be documented in the troubleshooting section.

Note: Since logback is triggered before Spring, we cannot leverage the org.zowe.apiml.message.log.ApimlLogger
Therefore, we have to use Slf4j, but we still document the ZWECS137W message under key org.zowe.apiml.cache.errorOpeningCachingFiles, so it will be reflected in Zowe doc.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

taban03 added 4 commits April 13, 2026 16:09
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
if (marker != null && APIML_MARKER.equals(marker.getName())) {
return FilterReply.NEUTRAL;
}
if (logger.getName().equals(TARGET_LOGGER) && format != null && format.contains("File") && format.contains("not found")) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using matches instead of twice contains?

Suggested change
if (logger.getName().equals(TARGET_LOGGER) && format != null && format.contains("File") && format.contains("not found")) {
if (logger.getName().equals(TARGET_LOGGER) && format != null && format.matches("File \\d not found")) {

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

2 participants