Remove no exp usage from logical rule Part II#3603
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Apr 8, 2026
fab65eb to
6d39967
Compare
6d39967 to
fdb2024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup PR of #3578
This PR deprecates
activation_kv_batch_no_expactivation_q_length_no_expactivation_attn_length_no_expfrom logical names.
After this change
activation_kv_batchalways includes "expert" physical axisactivation_q_lengthandactivation_attn_lengthdoes not include "expert"Other logical names containing "_no_exp" will be deprecated in following PR.
Tests
CI tests protecting
attention.py.Inference test:
Output: https://paste.googleplex.com/6211135167660032
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.