25.3.8-fips: fixes for verification issues#1616
Open
mkmkme wants to merge 3 commits intoreleases/25.3.8-fipsfrom
Open
25.3.8-fips: fixes for verification issues#1616mkmkme wants to merge 3 commits intoreleases/25.3.8-fipsfrom
mkmkme wants to merge 3 commits intoreleases/25.3.8-fipsfrom
Conversation
in SSL_set_bio, if `rbio == wbio`, there's an internal `BIO_up_ref` call by the function [1]. Doing it manually creates a memory leak. Let's fix it. [1] https://github.com/aws/aws-lc/blob/AWS-LC-FIPS-2.0.0/ssl/ssl_lib.cc#L748
Non-fips build uses `*_SIV` algorithms, so let's reflect it in `registerCodecEncrypted` as well.
on fips build, `*_SIV` are not defined. Let's fix it.
mkmkme
added
fips
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: