fix(nix): patch U2F PAM config with full Nix store path#2071
Draft
xPathin wants to merge 1 commit intoAvengeMedia:masterfrom
Draft
fix(nix): patch U2F PAM config with full Nix store path#2071xPathin wants to merge 1 commit intoAvengeMedia:masterfrom
xPathin wants to merge 1 commit intoAvengeMedia:masterfrom
Conversation
LuckShiba
approved these changes
Mar 24, 2026
Collaborator
LuckShiba
left a comment
There was a problem hiding this comment.
at least the code seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Nix flake build patches
assets/pam/fprintwith the full Nix store path topam_fprintd.so, but the same patch is missing forassets/pam/u2f. This causespam_u2f.soto fail with "Module is unknown" on NixOS because PAM can't resolve the short module name.This adds the matching
substituteInPlacefor the U2F PAM config.Related: #1910, #1911, #2050,
Test plan
cc @HirschBerge or any other Nix user can any of you test and quickly confirm that this fixes everything? Point your flake input to
github:xPathin/DankMaterialShell/fix/nixos-u2f-pam-pathand update + rebuild?