chore: update build script to use tsup configuration file and bump version to 1.0.1#16
chore: update build script to use tsup configuration file and bump version to 1.0.1#16
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s build setup by moving tsup options into a dedicated config file and updating the build script to reference it, alongside a patch version bump.
Changes:
- Added
tsup.config.tsto centralize build configuration. - Updated
package.jsonbuildscript to use the new config file and bumped version to1.0.1. - Updated README badges (removed npm downloads badge).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tsup.config.ts | Introduces centralized tsup build configuration. |
| package.json | Switches build script to config-based invocation and bumps package version. |
| README.md | Removes npm downloads badge from the header badge list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| entry: ['src/index.ts'], | ||
| format: ['cjs', 'esm'], | ||
| minify: true, | ||
| target: 'es2020', |
There was a problem hiding this comment.
minify: true changes the published JS output compared to the previous inline tsup invocation (which did not enable minification). If minification is not intended, drop this option; if it is intended, please call it out explicitly in the PR description / release notes since it affects consumer debugging and bundle characteristics.
| <p align="center"> | ||
| <a href="https://www.npmjs.com/package/@coderrob/typescript-type-guards"> | ||
| <img src="https://img.shields.io/npm/v/%40coderrob%2Ftypescript-type-guards?logo=npm&logoColor=white" alt="npm version" /> | ||
| </a> | ||
| <a href="https://www.npmjs.com/package/@coderrob/typescript-type-guards"> | ||
| <img src="https://img.shields.io/npm/dm/%40coderrob%2Ftypescript-type-guards?logo=npm&logoColor=white" alt="npm downloads" /> | ||
| </a> | ||
| <a href="https://github.com/Coderrob/typescript-type-guards/actions/workflows/ci.yml"> | ||
| <img src="https://img.shields.io/github/actions/workflow/status/Coderrob/typescript-type-guards/ci.yml?branch=main&label=ci" alt="CI status" /> | ||
| </a> |
There was a problem hiding this comment.
The npm downloads badge was removed from the README, but the PR description is scoped to build script/config changes and a version bump. If this removal is intentional, please update the PR description accordingly; otherwise, consider restoring the badge to keep the PR focused.
| "type": "commonjs", | ||
| "types": "dist/index.d.ts", | ||
| "version": "1.0.0" | ||
| "version": "1.0.1" |
There was a problem hiding this comment.
The repo appears to use Changesets for versioning (see CONTRIBUTING.md "Changesets" section), but this PR manually edits version. Consider adding a changeset and letting npm run release:version update package.json/CHANGELOG, or at least ensure the version bump is reflected consistently (e.g., package-lock.json still reports 1.0.0).
| "version": "1.0.1" | |
| "version": "1.0.0" |
This pull request updates the build process for the project by introducing a dedicated
tsupconfiguration file and updating the build script to use it. Additionally, it bumps the package version to1.0.1.Build process improvements:
tsup.config.tsfile to centralize and clarify the TypeScript build configuration, specifying options like entry points, output formats, type generation, minification, and target environment.buildscript inpackage.jsonto use the newtsupconfiguration file instead of inline options.Versioning:
1.0.0to1.0.1to reflect these configuration improvements.