feat: add PermeabilitySpecification as an high-level FieldSpecification#4012
Draft
kdrienCG wants to merge 6 commits intoGEOS-DEV:developfrom
Draft
feat: add PermeabilitySpecification as an high-level FieldSpecification#4012kdrienCG wants to merge 6 commits intoGEOS-DEV:developfrom
kdrienCG wants to merge 6 commits intoGEOS-DEV:developfrom
Conversation
Implement methods to add factories to the manager to handle the creation of FieldSpecificationBase object via higher-level specifications (like PermeabilitySpecification)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add an easy way to add higher-level components that create FieldSpecifications without the boilerplate.
As an example, to define the permeability you have to specify 3 differents FieldSpecifications.
One for the x-axis, a second for the y-axis, and a last one for the z-axis.
There is also some implementation details that could be hidden, like the
componentXML attribute for example.With this PR, their would be a
PermeabilitySpecificationcomponent that would create behind the scene those three FieldSpecifications to keep full compatibility with other parts that rely onFieldSpecificationBase. One could think of PermeabilitySpecification as a blueprint or recipe to create FieldSpecificationBase objects.Here is how it looks like for
PermeabilitySpecification:The following architecture is proposed:
This way, similar components could be added by providing a data class (like
PermeabilitySpecification) and a factory with ageneratemethod to describe how to transform the high-level components into one or multiple "low-level"FieldSpecificationBase.