fix(components): small UI tweaks for queries-over-time#1096
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “queries over time” UI to improve readability for long row labels and to simplify the row-label tooltip contents, aligning with issues #1094 and #1095.
Changes:
- Adjust row label rendering (spacing/no-wrap behavior) and update visual regression snapshots accordingly.
- Simplify the row-label tooltip by removing the “coverage query” section and improving count-query wrapping/width.
- Update the public util entrypoint export to expose
CountCoverageQuery(instead ofQueryDefinition) for richer tooltip metadata.
Reviewed changes
Copilot reviewed 4 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| components/src/preact/queriesOverTime/queries-over-time.tsx | Tweaks row label rendering inside the grid row-label tooltip wrapper. |
| components/src/preact/queriesOverTime/queries-over-time-row-label-tooltip.tsx | Removes coverage query section; adds max width and wraps count query. |
| components/src/preact/queriesOverTime/queries-over-time-row-label-tooltip.stories.tsx | Updates Storybook expectations/data to match tooltip changes. |
| components/src/utilEntrypoint.ts | Switches exported public type from QueryDefinition to CountCoverageQuery. |
| components/tests/snapshots.spec.ts-snapshots/Queries-over-time-Story-visualization-queries-over-time--*-chromium-linux.png | Updates/adds visual snapshots to reflect the UI changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
fengelniederhammer
approved these changes
Mar 11, 2026
fhennig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1094, resolves #1095
Summary
CountCoverageQueryinstead ofQueryDefinition.CountCoverageQueryactually includes a description for each variant, which is displayed in the tooltips.We're not using any sort of truncating on the variant name, because important parts of the name might be left out. For very long names this might look silly in the UI, but we're fine with that for now.
Screenshot
Don't wrap row labels, and added a little
mr-2to the label:No more coverage query:
max width and wrapping:
PR Checklist
All necessary documentation has been adapted.The implemented feature is covered by an appropriate test.