fix(logging): exclude noisy health/telemetry paths from request logs#1948
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
fix(logging): exclude noisy health/telemetry paths from request logs#1948kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
/global/health and /global/telemetry requests fire very frequently (health polls, telemetry pings) and flood worker logs. Add a QUIET_PATHS set to skip logging for these high-frequency paths in both the KiloClaw worker and the gastown container control server.
|
|
||
| async function logRequest(c: Context<AppEnv>, next: Next) { | ||
| const url = new URL(c.req.url); | ||
| if (QUIET_PATHS.has(url.pathname)) { |
Contributor
Author
There was a problem hiding this comment.
WARNING: Quiet-path check does not suppress the later proxy logs
This guard skips the top-level [REQ] line, but /global/health and /global/telemetry still hit the unconditional [PROXY] Handling request, [HTTP] Proxying, and [HTTP] Response status logs later in app.all('*', ...). The high-frequency polls will still flood worker logs, so this does not fully deliver the noise reduction described in the PR.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 544,398 tokens |
markijbema
requested changes
Apr 3, 2026
Contributor
markijbema
left a comment
There was a problem hiding this comment.
Bad bot, this makes no sense at all
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/global/healthand/global/telemetryfrom KiloClaw worker request logging — these high-frequency paths (health polls, telemetry pings) flood worker logs with noise, making it harder to spot meaningful requests./healthfrom gastown container control-server request logging for the same reason.QUIET_PATHSSet for O(1) lookups and easy extensibility.Verification
Set<string>+.has()check with early return)tsgobinary andnode_modulesin the CI environment, but the change is trivially safe — it adds a constantSetand anifguard before existing codeVisual Changes
N/A
Reviewer Notes
QUIET_PATHSpattern is intentionally a named constant (not inline) so future noisy paths can be added in one place.url.pathname(already computed) for the check; the control-server usesc.req.path(Hono's parsed path). Both are consistent with how the rest of each middleware already accesses the path./global/healthrequests.Built for Mark IJbema by Kilo for Slack