halshow: handle error when item from watchlist is removed during runtime#3907
Merged
andypugh merged 1 commit intoLinuxCNC:2.9from Apr 6, 2026
Merged
halshow: handle error when item from watchlist is removed during runtime#3907andypugh merged 1 commit intoLinuxCNC:2.9from
andypugh merged 1 commit intoLinuxCNC:2.9from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error: When there is a pin or parameter on Halshow's watchlist and the module gets unloaded so that the item no longer exists, halshow won't show the watchlist any more.
The same then you have a signal in the watchlist and remove that.
This fix catches the error. It shows the values as inactive until they get removed by the next refresh action (adding elements, resizing etc.)