Skip to content

halshow: handle error when item from watchlist is removed during runtime #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andypugh merged 1 commit into from
Apr 6, 2026
Merged

halshow: handle error when item from watchlist is removed during runtime #3907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions tcl/bin/halshow.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ proc watchHAL {which} {
# ptype (and getp) fail when the item clicked is not a leaf
# e.g., clicking "Pins / axis / 0"
if {[catch {hal ptype $varname} type]} {
setStatusbar $type
setStatusbar "Watch: $type"
return $type
}
}
Expand Down Expand Up @@ -1113,12 +1113,22 @@ proc setWatchInterval {} {

proc refreshItem {cnum vartype varname} {
if {$vartype == "sig" } {
set ret [hal gets $varname]
set varnumtype [hal stype $varname]
set getCmd gets
set typeCmd stype
} else {
set ret [hal getp $varname]
set varnumtype [hal ptype $varname]
set getCmd getp
set typeCmd ptype
}

if {[catch { set ret [hal $getCmd $varname] } error]} {
setStatusbar $error
$::cisp itemconfigure text$cnum -text "----"
$::cisp itemconfigure oval$cnum -fill lightgray
return
}

set varnumtype [hal $typeCmd $varname]

if {$ret == "TRUE"} {
$::cisp itemconfigure oval$cnum -fill yellow
} elseif {$ret == "FALSE"} {
Expand Down
Loading