Open
Conversation
ElectricalBoy
force-pushed
the
broadcast-talent-table-cleanup
branch
from
4c77c04 to
fa8788e
Compare
hjpalpha
approved these changes
Feb 24, 2026
ElectricalBoy
force-pushed
the
broadcast-talent-table-cleanup
branch
from
68d4083 to
3c93c21
Compare
Eetwalt
reviewed
Feb 26, 2026
Comment on lines
244
to
246
| {align = 'center'}, | ||
| {align = 'center'}, | ||
| {align = 'center'}, |
Collaborator
There was a problem hiding this comment.
Tournament -> left align, Position -> left align, what's the third?
Collaborator
Author
There was a problem hiding this comment.
first is league icon, second is tournament name, third is position
hjpalpha
reviewed
Feb 28, 2026
|
|
||
| self.aliases = args.aliases and Array.map(mw.text.split(args.aliases:gsub(' ', '_'), ','), String.trim) or {} | ||
| table.insert(self.aliases, self.broadcaster) | ||
| self.aliases = Array.map(Array.parseCommaSeparatedString(args.aliases), Page.pageifyLink) |
Collaborator
There was a problem hiding this comment.
are we sure we want to resolve redirect the aliases?
(we did not before)
Collaborator
Author
There was a problem hiding this comment.
should be safe as we resolve redirect before storing broadcasters already
| self.aliases = args.aliases and Array.map(mw.text.split(args.aliases:gsub(' ', '_'), ','), String.trim) or {} | ||
| table.insert(self.aliases, self.broadcaster) | ||
| self.aliases = Array.map(Array.parseCommaSeparatedString(args.aliases), Page.pageifyLink) | ||
| Array.appendWith(self.aliases, self.broadcaster) |
Collaborator
There was a problem hiding this comment.
would it make sense to slap Array.unique after this?
Collaborator
Author
There was a problem hiding this comment.
yes for completeness
though practically I don't think we need to - the only place that self.aliases is used is in LPDB condition building
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
StandardTournamentHow did you test this change?
https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox6