Fix premature assignment to optional argument before checking existence#1441
Open
islas wants to merge 1 commit intoMPAS-Dev:release-v8.4.0from
Open
Fix premature assignment to optional argument before checking existence#1441islas wants to merge 1 commit intoMPAS-Dev:release-v8.4.0from
islas wants to merge 1 commit intoMPAS-Dev:release-v8.4.0from
Conversation
islas
commented
Apr 6, 2026
| @@ -4107,6 +4107,10 @@ subroutine mpas_get_stream_filename(manager, streamID, when, blockID, filename, | |||
| end if | |||
Contributor
Author
There was a problem hiding this comment.
This if( present() ) statement above (line 4104) makes use of ierr and assigns to it instead of ierr_local - @mgduda I think it may make sense to also modify the assignment so that the final ierr assignment has the correct error code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no optional
ierrargument is provided in calling the subroutinempas_get_stream_filename()the model segfaults by trying to assign to the nonexistent argument. The function already has the necessary variables to capture local errors and then pass the value back to the caller, as is common in other routines throughout MPAS.These changes make use of the existing variable that may have just been unintentionally unused.