Skip to content

Fix premature assignment to optional argument before checking existence #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
islas wants to merge 1 commit into
base: release-v8.4.0
Choose a base branch
from
+5 −1
Open

Fix premature assignment to optional argument before checking existence #1441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/framework/mpas_stream_manager.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4073,7 +4073,7 @@ subroutine mpas_get_stream_filename(manager, streamID, when, blockID, filename,
type (MPAS_TimeInterval_type) :: filename_interval
type (MPAS_Time_type) :: now_time

ierr = 0
err_local = 0

if ( present(blockID) ) then
blockID_local = blockID
Expand Down Expand Up @@ -4107,6 +4107,10 @@ subroutine mpas_get_stream_filename(manager, streamID, when, blockID, filename,
end if
Copy link
Copy Markdown
Contributor Author

@islas islas Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if( present() ) statement above (line 4104) makes use of ierr and assigns to it instead of ierr_local - @mgduda I think it may make sense to also modify the assignment so that the final ierr assignment has the correct error code.

end if

if ( present(ierr) ) then
ierr = err_local
end if

end subroutine mpas_get_stream_filename !}}}


Expand Down