NWTC Library: Adjust subroutines for converting between DCM and small angles#3233
NWTC Library: Adjust subroutines for converting between DCM and small angles#3233bjonkman wants to merge 1 commit intoOpenFAST:devfrom
Conversation
- adjusted subroutines for computing small angles from DCM and the inverse routines to compute DCMs from small angles. These equations are accurate for larger angles. - This may already be in the v5.0.0 code
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
This matches what I would expect, with one change.
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Never mind. I see from the plan that the 2's cancel. This implementation looks correct. Thanks!
|
I looped through different angles, converting them to DCMs and then calling this code to get the "small" angles from of the DCM. I then plotted the difference between the starting angle and the calculated angles. As you can see, the error is small (taking into account for all 3 dimensions, the error was no larger than 1.1e-13 degrees). For reference, this is the plot with the original algorithm that we have now replaced: |
|
I'll look review the regression test changes and update them in the next few days for merging. Thanks @bjonkman! |
3 participants
Feature or improvement description
Adjusted subroutines for computing small angles from DCM and the inverse routines to compute DCMs from small angles. These equations are accurate for larger angles.
Related issue, if one exists
Impacted areas of the software
Additional supporting information
Test results, if applicable