feat(spp_drims): promote to Beta with view improvements#26
feat(spp_drims): promote to Beta with view improvements#26gonzalesedwin1123 merged 3 commits into19.0from
Conversation
- Promote spp_drims development_status from Alpha to Beta - Replace inherited alert views with standalone views matching DRIMS style - Fix Request Justification field to span full width (col=2, colspan=2) - Fix Return Reason field to span full width (col=2, colspan=2)
Summary of ChangesHello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly advances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully promotes the spp_drims module to Beta status and introduces several valuable UI improvements. The most significant change is the replacement of inherited alert views with standalone, DRIMS-styled views, which greatly enhances UI consistency and future maintainability. The new views are well-structured and more feature-rich. Additionally, the layout fixes for the 'Justification' and 'Return Reason' fields are correctly implemented, improving the form usability. The extensive code formatting changes across the XML files also improve readability. Overall, the changes are of high quality and align well with the stated goals.
- Add missing data/approval_definitions.xml to manifest
- Fix alert search filters: alert_type → alert_type_id.code
- Add @api.depends("sla_due_datetime") to _compute_sla_hours_remaining
Missing approval_type and approval_group_id caused ParseError on install.
Why is this change needed?
The spp_drims module has been manually verified and is ready for Beta status. Several UI inconsistencies were found during verification and fixed.
How was the change implemented?
development_statusfrom Alpha to Beta in__manifest__.pycol="2"andcolspan="2"to Request Justification and Return Reason fields so they span full widthNew unit tests
Unit tests executed by the author
How to test manually
Related links