Skip to content

feat(spp_drims): promote to Beta with view improvements#26

Merged
gonzalesedwin1123 merged 3 commits into19.0from
feat/drims-beta
Feb 11, 2026
Merged

feat(spp_drims): promote to Beta with view improvements#26
gonzalesedwin1123 merged 3 commits into19.0from
feat/drims-beta

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

The spp_drims module has been manually verified and is ready for Beta status. Several UI inconsistencies were found during verification and fixed.

How was the change implemented?

  • Updated development_status from Alpha to Beta in __manifest__.py
  • Replaced inherited alert views (from base spp_alerts) with standalone views matching the DRIMS visual style (donations, requests) — proper list decorations, button box with stat buttons, two-column form layout, search panel with filters
  • Added col="2" and colspan="2" to Request Justification and Return Reason fields so they span full width

New unit tests

Unit tests executed by the author

How to test manually

  • Install/upgrade spp_drims module
  • Verify DRIMS > Alerts list and form views match the style of Donations and Requests
  • Verify Request form > Justification field spans full width
  • Verify Return form > Return Reason field spans full width

Related links

- Promote spp_drims development_status from Alpha to Beta
- Replace inherited alert views with standalone views matching DRIMS style
- Fix Request Justification field to span full width (col=2, colspan=2)
- Fix Return Reason field to span full width (col=2, colspan=2)
@gemini-code-assist
Copy link

Summary of Changes

Hello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly advances the spp_drims module by promoting it to Beta status, reflecting its maturity and stability. A core focus of these changes is a comprehensive overhaul of the user interface for alerts, requests, and returns, ensuring a more consistent and user-friendly experience across the module. These improvements address previous UI inconsistencies and enhance the visual presentation and functionality of key forms and lists.

Highlights

  • Module Promotion to Beta: The spp_drims module has been promoted from Alpha to Beta development status, indicating increased stability and readiness for broader use.
  • Enhanced Alert Views: The alert list, form, and search views have been completely revamped, moving from inherited base views to standalone, custom DRIMS-specific designs. This includes new list decorations, a button box for quick actions, a two-column form layout, and an improved search panel with additional filters.
  • Improved Field Layouts: The 'Justification' field in the Request form and the 'Return Reason' field in the Return form now span the full width of their respective sections, improving readability and user experience.
Changelog
  • spp_drims/manifest.py
    • Updated the development_status from 'Alpha' to 'Beta'.
  • spp_drims/views/alert_views.xml
    • Replaced inherited alert list view with a new standalone list view, introducing custom decorations for priority and state, and adding new fields.
    • Replaced inherited alert form view with a new standalone form view, incorporating a button box for actions, a two-column layout for details, and a notebook for additional information.
    • Replaced inherited alert search view with a new standalone search view, adding a comprehensive search panel with filters for incident, state, priority, and alert type, along with various filter and group-by options.
    • Applied consistent XML formatting by adding spaces before self-closing tags.
  • spp_drims/views/request_views.xml
    • Adjusted the 'Justification' field within the Request form to span the full width by adding col="2" and colspan="2" to its group.
    • Applied consistent XML formatting by adding spaces before self-closing tags and wrapping attributes for readability across various view definitions (list, form, search, kanban, graph, pivot, actions).
  • spp_drims/views/return_views.xml
    • Adjusted the 'Return Reason' field within the Return form to span the full width by adding col="2" and colspan="2" to its group.
    • Applied consistent XML formatting by adding spaces before self-closing tags and wrapping attributes for readability across various view definitions (list, form, search, kanban, graph, pivot, and return line list).
Activity
  • The spp_drims module has been manually verified by the author, leading to its promotion to Beta status.
  • UI inconsistencies identified during verification were addressed and fixed as part of this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@emjay0921 emjay0921 marked this pull request as draft February 10, 2026 03:25
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully promotes the spp_drims module to Beta status and introduces several valuable UI improvements. The most significant change is the replacement of inherited alert views with standalone, DRIMS-styled views, which greatly enhances UI consistency and future maintainability. The new views are well-structured and more feature-rich. Additionally, the layout fixes for the 'Justification' and 'Return Reason' fields are correctly implemented, improving the form usability. The extensive code formatting changes across the XML files also improve readability. Overall, the changes are of high quality and align well with the stated goals.

- Add missing data/approval_definitions.xml to manifest
- Fix alert search filters: alert_type → alert_type_id.code
- Add @api.depends("sla_due_datetime") to _compute_sla_hours_remaining
Missing approval_type and approval_group_id caused ParseError on install.
@emjay0921 emjay0921 marked this pull request as ready for review February 11, 2026 01:05
@gonzalesedwin1123 gonzalesedwin1123 merged commit 68c270b into 19.0 Feb 11, 2026
17 of 18 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the feat/drims-beta branch February 11, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants