Skip to content

feat(spp_drims): promote to Beta with view improvements #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzalesedwin1123 merged 3 commits into from
Feb 11, 2026
Merged

feat(spp_drims): promote to Beta with view improvements #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b17a746
feat(spp_drims): promote to Beta with view improvements
emjay0921 Feb 10, 2026
031b305
fix(spp_drims): fix 3 critical audit issues
emjay0921 Feb 10, 2026
505b4bf
fix(spp_drims): add required approval_type and group to definitions
emjay0921 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spp_drims/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"author": "OpenSPP.org",
"website": "https://github.com/OpenSPP/OpenSPP2",
"license": "LGPL-3",
"development_status": "Alpha",
"development_status": "Beta",
"maintainers": ["jeremi", "gonzalesedwin1123"],
"depends": [
"base",
Expand Down Expand Up @@ -43,6 +43,7 @@
"data/audit_rules.xml",
"data/config_defaults.xml",
"data/gis_report_templates.xml",
"data/approval_definitions.xml",
# Reports (before views, as views may reference report actions)
"report/waybill_template.xml",
"views/dashboard_views.xml",
Expand Down
15 changes: 15 additions & 0 deletions spp_drims/data/approval_definitions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
<field name="active">True</field>
<field name="sla_days">0</field>
<field name="sequence">1</field>
<field name="approval_type">group</field>
<field name="approval_group_id" ref="group_drims_manager"/>
<field name="is_emergency_bypass_allowed">True</field>
<field name="notify_on_submit">True</field>
</record>

<!-- Standard Approval (Small Value) -->
Expand All @@ -23,6 +27,9 @@
<field name="active">True</field>
<field name="sla_days">1</field>
<field name="sequence">10</field>
<field name="approval_type">group</field>
<field name="approval_group_id" ref="group_drims_approver"/>
<field name="notify_on_submit">True</field>
</record>

<!-- Medium Value Approval -->
Expand All @@ -32,6 +39,10 @@
<field name="active">True</field>
<field name="sla_days">2</field>
<field name="sequence">20</field>
<field name="approval_type">group</field>
<field name="approval_group_id" ref="group_drims_approver"/>
<field name="is_require_comment">True</field>
<field name="notify_on_submit">True</field>
</record>

<!-- Large Value Approval -->
Expand All @@ -41,5 +52,9 @@
<field name="active">True</field>
<field name="sla_days">3</field>
<field name="sequence">30</field>
<field name="approval_type">group</field>
<field name="approval_group_id" ref="group_drims_manager"/>
<field name="is_require_comment">True</field>
<field name="notify_on_submit">True</field>
</record>
</odoo>
1 change: 1 addition & 0 deletions spp_drims/models/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ def _compute_sla_status(self):
rec.sla_due_datetime = False
rec.sla_status = False

@api.depends("sla_due_datetime")
def _compute_sla_hours_remaining(self):
"""Compute hours remaining until SLA breach."""
now = fields.Datetime.now()
Expand Down
Loading
Loading