ORAS Mirage Spots - Cave and Mountain Encounters#1447
Open
ItsMeJoji wants to merge 23 commits intoPokeAPI:masterfrom
Open
ORAS Mirage Spots - Cave and Mountain Encounters#1447ItsMeJoji wants to merge 23 commits intoPokeAPI:masterfrom
ItsMeJoji wants to merge 23 commits intoPokeAPI:masterfrom
Conversation
I realized after creating this PR that the IDs in the encounter.csv were incorrect at the end of it.
Removed --break-system-packages option from install and dev-install commands. Usually need this for my own machine.
Contributor
|
Thanks for the grace @ItsMeJoji. I actually have a question! It looks like you made this an upstream of the mirage forest PR you initially made. I tried to do that with my XD pr with the Colo one I made, but after my Colo pr got merged it said my branch was incompatible. I think GitHub for some reason thought all my previous commits were different? Can you describe how you did this upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final ORAS Mirage Spot encounter for Mirage Cave and Mirage Mountain.
I believe there's a commit @notblisy is working on that affects files I'm pushing, so we can confirm and pull their PR before mine. Once theirs's is approved, I'll sync up mine.