Fix deploy: replace stale base Docker image with python:3.11#3298
Merged
Fix deploy: replace stale base Docker image with python:3.11#3298
Conversation
The deploy Dockerfile inherited from policyengine/policyengine-api:latest on Docker Hub, which was last pushed in July 2024 and uses Python 3.10. Since setup.py now requires >=3.11, deploys fail. Rather than rebuilding the base image, this removes the indirection entirely — the base image only pre-installed heavy deps as a cache layer, but since version pins change frequently the cache provided minimal benefit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
+ Coverage 70.10% 72.07% +1.97%
==========================================
Files 56 56
Lines 2398 2396 -2
Branches 419 419
==========================================
+ Hits 1681 1727 +46
+ Misses 641 591 -50
- Partials 76 78 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FROM policyengine/policyengine-api:latestwithFROM python:3.11in the deploy Dockerfilebuild-essentialandredis-serversystem deps inline (previously provided by the base image)The base image on Docker Hub was last pushed July 2024 and uses Python 3.10. Since
setup.pynow requires>=3.11, all deploys fail with:The base image existed as a cache layer to pre-install heavy dependencies, but since version pins change frequently it provided minimal speedup and added maintenance burden.
Fixes #3297
Test plan
make deployand verify the build completes successfully🤖 Generated with Claude Code