[TensileLite] Fix YAML parameter type mismatches — mid archs#5681
Merged
[TensileLite] Fix YAML parameter type mismatches — mid archs#5681
Conversation
Fix bool/int/float type mismatches in library logic YAML files for: aldebaran, gfx1200, gfx1201 YAML `false`/`true` where `int 0`/`1` is expected (and vice versa) produce different msgpack wire types, causing `std::bad_cast` at C++ deserialization time. Generated by `utilities/fix_yaml_types.py`. Zero mismatches remain. Refs: AIGECORE-189 Depends on: #5001 (fix wrong-type literals in assignDerivedParameters) #5002 (add build-time type validation for library logic YAMLs) --- Merge conflict resolution --- If you are resolving a merge conflict between this commit and a tuning update to these YAML files: your tuning changes take precedence. For each conflicted file, accept your version of the file. After resolving all conflicts and staging the files, run: python3 utilities/fix_yaml_types.py <arch_directory> to re-apply the type fixes on top of your tuning data. Verify it reports zero mismatches, then complete the merge/rebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Note: although the Github UI shows 0 files changed. The commit is here: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.21%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5681 +/- ##
========================================
Coverage 67.36% 67.36%
========================================
Files 1848 1848
Lines 284774 284774
Branches 40002 40002
========================================
Hits 191814 191814
Misses 76503 76503
Partials 16457 16457
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
perfci run on commit 473fcad |
davidd-amd
approved these changes
Mar 23, 2026
COrruDXC
pushed a commit
to COrruDXC/rocm-libraries
that referenced
this pull request
Mar 24, 2026
## Motivation YAML `false`/`true` where `int 0`/`1` is expected (and vice versa) produce different msgpack wire types, causing `std::bad_cast` at C++ deserialization time on any multi-architecture build where a wrong-type .dat file is loaded. This fixes the existing mismatches in the mid architecture group. Refs: AIGECORE-189 Depends on: ROCm#5001, ROCm#5002 ## Technical Details Mechanical fix generated by `utilities/fix_yaml_types.py` for: aldebaran, gfx1200, gfx1201 414 files changed. Zero mismatches remain after fix. See ROCm#5002 for full background on the bug, the affected parameters, and the landing strategy. This is one of 4 independent YAML fix PRs (small archs, mid archs, gfx950, aquavanjaram) that can be merged in any order. ## Test Plan - Run `utilities/fix_yaml_types.py <arch_dir>` on each architecture directory — verify it reports 0 mismatches (idempotent check) - Build hipblaslt with `--architecture` including these archs — ROCm#5002 validation should emit no warnings for these files ## Test Result `fix_yaml_types.py` reports zero remaining mismatches across all 414 files. ## Merge Conflict Resolution If you are resolving a merge conflict between this commit and a tuning update to these YAML files: your tuning changes take precedence. For each conflicted file, accept your version of the file. After resolving all conflicts and staging the files, run: python3 utilities/fix_yaml_types.py <arch_directory> to re-apply the type fixes on top of your tuning data. Verify it reports zero mismatches, then complete the merge/rebase. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
YAML
false/truewhereint 0/1is expected (and vice versa) producedifferent msgpack wire types, causing
std::bad_castat C++ deserializationtime on any multi-architecture build where a wrong-type .dat file is loaded.
This fixes the existing mismatches in the mid architecture group.
Refs: AIGECORE-189
Depends on: #5001, #5002
Technical Details
Mechanical fix generated by
utilities/fix_yaml_types.pyfor:aldebaran, gfx1200, gfx1201
414 files changed. Zero mismatches remain after fix.
See #5002 for full background on the bug, the affected parameters, and the
landing strategy. This is one of 4 independent YAML fix PRs (small archs,
mid archs, gfx950, aquavanjaram) that can be merged in any order.
Test Plan
utilities/fix_yaml_types.py <arch_dir>on each architecturedirectory — verify it reports 0 mismatches (idempotent check)
--architectureincluding these archs — [TensileLite] Add build-time type validation for library logic YAMLs #5002validation should emit no warnings for these files
Test Result
fix_yaml_types.pyreports zero remaining mismatches across all 414 files.Merge Conflict Resolution
If you are resolving a merge conflict between this commit and a tuning
update to these YAML files: your tuning changes take precedence. For each
conflicted file, accept your version of the file. After resolving all
conflicts and staging the files, run:
to re-apply the type fixes on top of your tuning data. Verify it reports
zero mismatches, then complete the merge/rebase.
Submission Checklist