Export CSV config revamp to support table exports#199
Open
davidwzhao wants to merge 26 commits intomainfrom
Open
Export CSV config revamp to support table exports#199davidwzhao wants to merge 26 commits intomainfrom
davidwzhao wants to merge 26 commits intomainfrom
Conversation
comnik
reviewed
Feb 17, 2026
Comment on lines
313
to
314
| // Partitioning (for export) | ||
| int64 partition_size = 12; |
Collaborator
There was a problem hiding this comment.
I think there was some desire to name this partition_size_mb? 🤔 Maybe I'm misremembering. I personally don't mind either way.
Contributor
There was a problem hiding this comment.
I think that would be https://relationalai.atlassian.net/browse/RAI-47099
davidwzhao
changed the title
mmcgr
approved these changes
Feb 20, 2026
Contributor
mmcgr
left a comment
mmcgr
left a comment
There was a problem hiding this comment.
Thanks!
Just one tiny nit.
| decimal_separator: str = _extract_value_string(builtin.dict_get(config, "csv_decimal_separator"), ".") | ||
| encoding: str = _extract_value_string(builtin.dict_get(config, "csv_encoding"), "utf-8") | ||
| compression: str = _extract_value_string(builtin.dict_get(config, "csv_compression"), "auto") | ||
| partition_size: int = _extract_value_int64(builtin.dict_get(config, "csv_partition_size_mb"), 0) |
Contributor
There was a problem hiding this comment.
Suggested change
| partition_size: int = _extract_value_int64(builtin.dict_get(config, "csv_partition_size_mb"), 0) | |
| partition_size_mb: int = _extract_value_int64(builtin.dict_get(config, "csv_partition_size_mb"), 0) |
and a matching update in the return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add export_csv_config_v2 with csv_source and table_def support
Adds grammar and printer support for the
export_csv_config_v2format, which uses the existingExportCSVConfigproto fieldscsv_sourceandcsv_configto provide a cleaner separation between data source specification and CSV formatting options.Protobuf Structure
ExportCSVConfignow supports two patterns:data_columns(repeated ExportCSVColumn) with inline syntax_* and compression optionscsv_source(ExportCSVSource) andcsv_config(CSVConfig), where:csv_sourceis a oneof containing eithertable_deforgnf_columnscsv_configis a CSVConfig object with csv_* prefixed options (header_row, delimiter, compression, etc.)Changes
export_csv_config_v2parser/printer rules using csv_source and csv_configtable_defandgnf_columnsin the v2 formatAlso renamed
CSVConfig.partition_size→partition_size_mbfor clarity.(thanks Claude for the description 😄)