feat: enhance ask_followup_question to support multiple questions #11139

ScDor · 2026-01-31T11:48:57Z

This PR enhances the ask_followup_question tool to support multiple questions and optional multiple-choice responses.

Key changes:

Updated ask_followup_question schema to accept a questions array.
Support for Question objects with text and options.
New UI for handling multiple questions (all at once or one by one).
Added user settings to toggle one-by-one question display.
Improved streaming logic to show the first question while accumulating others.
Fully migrated to native tool calling protocol.
Added comprehensive unit and UI tests.

Important

Enhance ask_followup_question to support multiple questions and multiple-choice responses, with updated schema, UI, and tests.

Behavior:
- ask_followup_question now supports multiple questions and multiple-choice options.
- Updated ask_followup_question schema in ask_followup_question.ts to accept questions array.
- New UI component MultiQuestionHandler in ChatRow.tsx to handle multiple questions.
- Added user setting showQuestionsOneByOne in UISettings.tsx to toggle question display mode.
- Improved streaming logic in AskFollowupQuestionTool.ts to show first question while accumulating others.
Tests:
- Added tests for MultiQuestionHandler in MultiQuestionHandler.spec.tsx.
- Updated tests in askFollowupQuestionTool.spec.ts to cover new functionality.
Misc:
- Added showQuestionsOneByOne setting to ExtensionStateContext.tsx and SettingsView.tsx.
- Updated translations in chat.json for new question handling.

^{This description was created by}^{for d3028c3. You can customize this summary. It will automatically update as commits are pushed.}

- Separate navigation logic from submission logic in MultiQuestionHandler - Add dedicated handleFinish function to send combined responses - Prevent immediate sending when navigating between questions - Add comprehensive tests to verify the UX fix - All existing functionality preserved, tests passing

roomote · 2026-01-31T11:49:24Z

Rooviewer See task

Reviewed 5c5811c (Indonesian translation fix). The Vietnamese word in the Indonesian locale is now corrected. One previously flagged issue remains unresolved.

Missing translation keys for showQuestionsOneByOne UI setting in settings.json
Type mismatch between FollowUpData interface (string[]) and actual runtime data (Array<string | { text: string; options?: string[] }>)
showQuestionsOneByOne not wired into ClineProvider.getState() / getStateToPostToWebview()
Missing taskHeaderHighlight translation keys in all locale files (UI shows raw key strings)
taskHeaderHighlightEnabled removed from save payload but toggle still rendered in UISettings
Vietnamese word "t\u1eeb" used in Indonesian locale id/settings.json instead of Indonesian "dari"

Previous reviews

b3eb2ab: Review #1

30ae16c: Review #2

06b957a: Review #3

938ae63: Review #4

782caa6: Review #5

c9b6ffd: Review #6

4ca2ded: Review #7

08d7bfa: Review #8

5393c2b: Review #9

d3028c3: Review #10

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

roomote · 2026-01-31T11:52:20Z

webview-ui/src/components/settings/UISettings.tsx

+					<SearchableSetting
+						settingId="ui-show-questions-one-by-one"
+						section="ui"
+						label={t("settings:ui.showQuestionsOneByOne.label")}>
+						<div className="flex flex-col gap-1">
+							<VSCodeCheckbox
+								checked={showQuestionsOneByOne}
+								onChange={(e: any) => handleShowQuestionsOneByOneChange(e.target.checked)}
+								data-testid="show-questions-one-by-one-checkbox">
+								<span className="font-medium">{t("settings:ui.showQuestionsOneByOne.label")}</span>
+							</VSCodeCheckbox>
+							<div className="text-vscode-descriptionForeground text-sm ml-5 mt-1">
+								{t("settings:ui.showQuestionsOneByOne.description")}
+							</div>
+						</div>
+					</SearchableSetting>


Missing translation keys. The settings:ui.showQuestionsOneByOne.label and settings:ui.showQuestionsOneByOne.description keys are referenced here but not defined in webview-ui/src/i18n/locales/en/settings.json. The UI section in that file only has collapseThinking and requireCtrlEnterToSend. This will cause the raw translation keys to be displayed in the UI instead of human-readable text.

_{Fix it with Roo Code or mention @roomote and request a fix.}

packages/types/src/followup.ts

…licts

…25-multi-question

…in, and ensure PR is green

roomote · 2026-02-09T22:20:19Z

packages/types/src/vscode-extension-host.ts

 	| "enterBehavior"
 	| "includeCurrentTime"
 	| "includeCurrentCost"
+	| "showQuestionsOneByOne"


showQuestionsOneByOne is added to ExtensionState here, but ClineProvider.ts never includes it in the state objects returned by getState() or getStateToPostToWebview(). Every other UI setting in this Pick type (e.g., enterBehavior, includeCurrentCost, taskHeaderHighlightEnabled) is explicitly included in both methods. Without the same wiring, the setting value stored via contextProxy.setValue is never sent back to the webview -- it will always default to false on initial load and after webview reloads, and the ExtensionStateContext check at line 343 ((newState as any).showQuestionsOneByOne) will never trigger. You need to add showQuestionsOneByOne to the destructured values from getState() (~line 2082), and include showQuestionsOneByOne: showQuestionsOneByOne ?? false in both state return objects (near lines 2228 and 2470).

_{Fix it with Roo Code or mention @roomote and request a fix.}

…licts

roomote · 2026-02-09T22:55:42Z

webview-ui/src/components/settings/UISettings.tsx

+					<SearchableSetting
+						settingId="ui-task-header-highlight"
+						section="ui"
+						label={t("settings:ui.taskHeaderHighlight.label")}>
+						<div className="flex flex-col gap-1">
+							<VSCodeCheckbox
+								checked={taskHeaderHighlightEnabled}
+								onChange={(e: any) => handleTaskHeaderHighlightChange(e.target.checked)}
+								data-testid="task-header-highlight-checkbox">
+								<span className="font-medium">{t("settings:ui.taskHeaderHighlight.label")}</span>
+							</VSCodeCheckbox>
+							<div className="text-vscode-descriptionForeground text-sm ml-5 mt-1">
+								{t("settings:ui.taskHeaderHighlight.description")}
+							</div>
+						</div>
+					</SearchableSetting>


The translation keys settings:ui.taskHeaderHighlight.label and settings:ui.taskHeaderHighlight.description referenced here don't exist in any locale's settings.json. The old taskCompleteColor keys were removed during the merge with main (which reverted the highlight feature in #11349), but the replacement taskHeaderHighlight keys were never added. Users will see raw key strings like settings:ui.taskHeaderHighlight.label in the settings UI. Either add the translation keys to all locale files, or remove this setting block entirely since the highlight feature it controls was reverted on main and TaskHeader.tsx no longer reads taskHeaderHighlightEnabled.

_{Fix it with Roo Code or mention @roomote and request a fix.}

@roomote fix it

Fixaroo See task

Removed the orphaned taskHeaderHighlight setting block, handler, and prop from UISettings since the feature was reverted on main and the translation keys were never added. All lint, type checks, and tests pass.

_{View commit | Revert commit}

roomote · 2026-02-09T22:55:48Z

webview-ui/src/components/settings/SettingsView.tsx

 					enterBehavior: enterBehavior ?? "send",
 					includeCurrentTime: includeCurrentTime ?? true,
 					includeCurrentCost: includeCurrentCost ?? true,
+					showQuestionsOneByOne: showQuestionsOneByOne ?? false,


taskHeaderHighlightEnabled was removed from this save payload during the merge resolution (the diff shows -taskHeaderHighlightEnabled,), but the setting toggle was kept in UISettings. This means the checkbox renders in the UI but toggling it and clicking Save has no effect -- the value is never sent to the extension host. If the setting should be preserved, add taskHeaderHighlightEnabled: taskHeaderHighlightEnabled ?? false, here alongside the other UI settings. If the intent is to remove it (since the highlight was reverted on main), remove the toggle from UISettings.tsx as well.

_{Fix it with Roo Code or mention @roomote and request a fix.}

@roomote fix

Fixaroo See task

Removed the orphaned taskHeaderHighlightEnabled setting that leaked back in during the merge resolution (the feature was reverted on main). Cleaned up all 7 affected files. All local checks passed (lint, type-check, tests).

_{View commit | Revert commit}

…ht features

webview-ui/src/i18n/locales/id/settings.json

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

ScDor added 4 commits January 16, 2026 18:30

feat: enhance ask_followup_question to support multiple questions

b7ea247

feat: implement multi-question support with options and UI enhancements

5521e0d

Merge origin/main into vk/6325-multi-question and resolve conflicts

d3028c3

ScDor requested review from cte, jr and mrubens as code owners January 31, 2026 11:48

github-project-automation bot added this to Roo Code Roadmap Jan 31, 2026

github-project-automation bot moved this to New in Roo Code Roadmap Jan 31, 2026

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Jan 31, 2026

roomote bot reviewed Jan 31, 2026

View reviewed changes

packages/types/src/followup.ts Outdated Show resolved Hide resolved

ScDor added 2 commits February 5, 2026 13:49

fix: resolve automated review issues for ask_followup_question

5393c2b

fix: revert unwanted changes in zh-TW README

08d7bfa

roomote bot approved these changes Feb 5, 2026

View reviewed changes

ScDor added 2 commits February 9, 2026 23:51

chore: merge origin/main into vk/6325-multi-question and resolve conf…

621ab32

…licts

Merge remote-tracking branch 'fork/vk/6325-multi-question' into vk/63…

4ca2ded

…25-multi-question

ScDor requested review from daniel-lxs and hannesrudolph as code owners February 9, 2026 22:09

ScDor added 2 commits February 10, 2026 00:10

docs(quick-1): check branch with PR, fix build failures, pull from ma…

07b7219

…in, and ensure PR is green

fix: add missing translations for multi-question feature

c9b6ffd

roomote bot reviewed Feb 9, 2026

View reviewed changes

roomote bot approved these changes Feb 9, 2026

View reviewed changes

fix: address PR feedback and fix unit test failures

782caa6

roomote bot approved these changes Feb 9, 2026

View reviewed changes

ScDor added 2 commits February 10, 2026 00:40

chore: merge origin/main into vk/6325-multi-question and resolve conf…

c947059

…licts

chore: resolve remaining conflicts and wire taskHeaderHighlightEnabled

938ae63

roomote bot reviewed Feb 9, 2026

View reviewed changes

ScDor added 3 commits February 10, 2026 13:49

chore: remove internal planning and documentation files

06b957a

chore: revert unintended documentation and UI changes

30ae16c

chore: update translations for multi-question and task header highlig…

b3eb2ab

…ht features

roomote bot reviewed Feb 10, 2026

View reviewed changes

webview-ui/src/i18n/locales/id/settings.json Outdated Show resolved Hide resolved

Update webview-ui/src/i18n/locales/id/settings.json

5c5811c

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enhance ask_followup_question to support multiple questions #11139

feat: enhance ask_followup_question to support multiple questions #11139

Uh oh!

ScDor commented Jan 31, 2026 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

roomote bot Jan 31, 2026

Uh oh!

Uh oh!

roomote bot Feb 9, 2026

Uh oh!

roomote bot Feb 9, 2026

Uh oh!

ScDor Feb 9, 2026

Uh oh!

roomote bot Feb 9, 2026 •

edited

Loading

Uh oh!

roomote bot Feb 9, 2026

Uh oh!

ScDor Feb 9, 2026

Uh oh!

roomote bot Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat: enhance ask_followup_question to support multiple questions #11139

Are you sure you want to change the base?

feat: enhance ask_followup_question to support multiple questions #11139

Uh oh!

Conversation

ScDor commented Jan 31, 2026 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roomote bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roomote bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roomote bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

roomote bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

ScDor Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

roomote bot Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roomote bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

ScDor Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

roomote bot Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ScDor commented Jan 31, 2026 •

edited by ellipsis-dev bot

Loading

roomote bot commented Jan 31, 2026 •

edited

Loading

roomote bot Feb 9, 2026 •

edited

Loading

roomote bot Feb 9, 2026 •

edited

Loading