-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: enhance ask_followup_question to support multiple questions #11139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScDor
wants to merge
17
commits into
RooCodeInc:main
Choose a base branch
from
ScDor:vk/6325-multi-question
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b7ea247
feat: enhance ask_followup_question to support multiple questions
ScDor 08aa544
Fix multi-question UX: only send responses when Finish is clicked
ScDor 5521e0d
feat: implement multi-question support with options and UI enhancements
ScDor d3028c3
Merge origin/main into vk/6325-multi-question and resolve conflicts
ScDor 5393c2b
fix: resolve automated review issues for ask_followup_question
ScDor 08d7bfa
fix: revert unwanted changes in zh-TW README
ScDor 621ab32
chore: merge origin/main into vk/6325-multi-question and resolve conf…
ScDor 4ca2ded
Merge remote-tracking branch 'fork/vk/6325-multi-question' into vk/63…
ScDor 07b7219
docs(quick-1): check branch with PR, fix build failures, pull from ma…
ScDor c9b6ffd
fix: add missing translations for multi-question feature
ScDor 782caa6
fix: address PR feedback and fix unit test failures
ScDor c947059
chore: merge origin/main into vk/6325-multi-question and resolve conf…
ScDor 938ae63
chore: resolve remaining conflicts and wire taskHeaderHighlightEnabled
ScDor 06b957a
chore: remove internal planning and documentation files
ScDor 30ae16c
chore: revert unintended documentation and UI changes
ScDor b3eb2ab
chore: update translations for multi-question and task header highlig…
ScDor 5c5811c
Update webview-ui/src/i18n/locales/id/settings.json
ScDor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showQuestionsOneByOneis added toExtensionStatehere, butClineProvider.tsnever includes it in the state objects returned bygetState()orgetStateToPostToWebview(). Every other UI setting in this Pick type (e.g.,enterBehavior,includeCurrentCost,taskHeaderHighlightEnabled) is explicitly included in both methods. Without the same wiring, the setting value stored viacontextProxy.setValueis never sent back to the webview -- it will always default tofalseon initial load and after webview reloads, and theExtensionStateContextcheck at line 343 ((newState as any).showQuestionsOneByOne) will never trigger. You need to addshowQuestionsOneByOneto the destructured values fromgetState()(~line 2082), and includeshowQuestionsOneByOne: showQuestionsOneByOne ?? falsein both state return objects (near lines 2228 and 2470).Fix it with Roo Code or mention @roomote and request a fix.