fix(native-tools): accept empty attempt_completion.result #11405
+69
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #11404
Summary
attempt_completionnativeArgs gating from truthiness (if (args.result)) to existence check (if (args.result !== undefined)) in both the streaming partial parse path and the finalize parse path inNativeToolCallParser.ts""is falsy in JavaScript, soresult: ""was incorrectly treated as missing, producing the "missing nativeArgs" errorTest plan
attempt_completionedge cases (empty string, non-empty, missing, streaming empty)