Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/assistant-message/NativeToolCallParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ export class NativeToolCallParser {
break

case "attempt_completion":
if (partialArgs.result) {
if (partialArgs.result !== undefined) {
nativeArgs = { result: partialArgs.result }
}
break
Expand Down Expand Up @@ -790,7 +790,7 @@ export class NativeToolCallParser {
break

case "attempt_completion":
if (args.result) {
if (args.result !== undefined) {
nativeArgs = { result: args.result } as NativeArgsFor<TName>
}
break
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,73 @@ describe("NativeToolCallParser", () => {
})
})

describe("parseToolCall - attempt_completion", () => {
it("should produce nativeArgs when result is an empty string", () => {
const toolCall = {
id: "toolu_empty_result",
name: "attempt_completion" as const,
arguments: JSON.stringify({ result: "" }),
}

const result = NativeToolCallParser.parseToolCall(toolCall)

expect(result).not.toBeNull()
expect(result?.type).toBe("tool_use")
if (result?.type === "tool_use") {
expect(result.nativeArgs).toBeDefined()
const nativeArgs = result.nativeArgs as { result: string }
expect(nativeArgs.result).toBe("")
}
})

it("should produce nativeArgs when result is a non-empty string", () => {
const toolCall = {
id: "toolu_normal_result",
name: "attempt_completion" as const,
arguments: JSON.stringify({ result: "Task completed successfully." }),
}

const result = NativeToolCallParser.parseToolCall(toolCall)

expect(result).not.toBeNull()
expect(result?.type).toBe("tool_use")
if (result?.type === "tool_use") {
expect(result.nativeArgs).toBeDefined()
const nativeArgs = result.nativeArgs as { result: string }
expect(nativeArgs.result).toBe("Task completed successfully.")
}
})

it("should return null when result is missing entirely", () => {
const toolCall = {
id: "toolu_no_result",
name: "attempt_completion" as const,
arguments: JSON.stringify({}),
}

const result = NativeToolCallParser.parseToolCall(toolCall)

expect(result).toBeNull()
})
})

describe("processStreamingChunk - attempt_completion", () => {
it("should produce nativeArgs during streaming when result is an empty string", () => {
const id = "toolu_stream_empty_completion"
NativeToolCallParser.startStreamingToolCall(id, "attempt_completion")

const result = NativeToolCallParser.processStreamingChunk(
id,
JSON.stringify({ result: "" }),
)

expect(result).not.toBeNull()
expect(result?.nativeArgs).toBeDefined()
const nativeArgs = result?.nativeArgs as { result: string }
expect(nativeArgs.result).toBe("")
})
})

describe("processStreamingChunk", () => {
describe("read_file tool", () => {
it("should emit a partial ToolUse with nativeArgs.path during streaming", () => {
Expand Down
Loading