Light Calorimetry by lynnt20 · Pull Request #878 · SBNSoftware/sbndcode

lynnt20 · 2025-11-19T20:09:54Z

Description

Add producer module to create light calorimetry data products. Creates new subdirectory Calorimetry to store the module and fcls. Over 3 years since the first commit! Reco2/caf level changes only.

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links

Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

Version v09_67_00

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet

- merge the two previous trees into one - match-type can now differentiate between event/slice level easily

Version v09_89_01, patch release for SBN2024A

Version v09_93_01_02p02

Version v10_04_07

linyan-w · 2026-01-28T18:45:11Z

Adding sim/reco group conveners for additional sign-off.
Please note that this is a new feature that is

reco2 & downstream
does not conflict with anything else

We will merge with any of the conveners sign-off on it from the physics & organization perspective. Lynn's CM presentation here:
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=44953

ups/product_deps

linyan-w

Looks good to me! One nitpicking comment: Is the Noise Threshold and Max Threshold unique to light calorimetry? If so great. Otherwise it would be nice to check that's the globally used values.

lynnt20 · 2026-01-28T20:06:21Z

Looks good to me! One nitpicking comment: Is the Noise Threshold and Max Threshold unique to light calorimetry? If so great. Otherwise it would be nice to check that's the globally used values.

@linyan-w They are unique to this module, so no globally used values here.

henrylay97

In general this looks great @lynnt20! Thanks for the comprehensive approach. Also you should get an award for perseverance in not letting this branch die!

A few small comments, some of which can be ignored at your discretion.

CMakeLists.txt

sbndcode/Calorimetry/LightCaloProducer_module.cc

sbndcode/Calorimetry/run_lightcalo.fcl

sbndcode/JobConfigurations/standard/reco/config/workflow_reco2.fcl

…ing messages; avoid hardcoded TPC tick

This reverts commit 6ff86f1.

…e data fcl configuration

Version v10_14_02_01

nathanielerowe · 2026-01-29T19:09:33Z

Can you resolve merge conflicts when you get a chance? Thanks!

lynnt20 · 2026-01-29T20:39:56Z

@sungbinoh, I added functionality to access TPC Calibration database to grab the electron lifetime for data. Would you mind reviewing that part of the code (producer module and data flc)? Thank you!

henrylay97

Thanks for the swift updates, looks great!

henrylay97 · 2026-01-30T09:22:52Z

sbndcode/Calorimetry/LightCaloProducer_module.cc

+
+  // Query database - translate run into fake "timestamp" 
+  // (same convention as NormalizeDriftSQLite)
+  felifetime_db->UpdateData((run + 1000000000) * 1000000000);


General comment for all of us, and this can be punted to a separate PR. Should we have a single place where the fake "timestamp" is formed? So that when we inevitably end up changing the prescription in future we only have one point of maintenance.

@sungbinoh may have thoughts

nathanielerowe · 2026-02-05T15:31:32Z

This will need a production/sbnd-gen2 PR as well now

nathanielerowe · 2026-02-17T00:40:46Z

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-02-17T01:29:45Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T01:37:45Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T01:45:52Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-02-17T01:57:08Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2026-02-17T14:35:59Z

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#619 SBNSoftware/sbnanaobj#181 SBNSoftware/sbnobj/#158 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-02-17T14:51:32Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T14:59:13Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T15:02:35Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-02-17T15:23:43Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

lynnt20 added 30 commits January 10, 2023 23:58

first build + commit

94c59df

added root tree, more explicit cut parameters, and opflashes

08bd042

first commit of light reco attempt using visibility map

fa2b8a7

working version with reco/true comparisons

ccea7c6

added backtracker info

afea365

cleaned up trees, added wire assn, gamma weighted avg, true hit info

7ed0f0e

clean up truth/reco hit information

31847f3

add calibration constants for all planes

b119273

use all hits instead of spacepoints->hits

55032e6

clean up calorimetry cmakelists

fea4bf4

calculate median as light estimate

477b63a

removed unweighted fcl, added arapucas and noise threshold

eea4729

fix tpc split bug, comitting debugging couts, add mean+median functions

081f01d

cleanup

91ad097

cleanup: remove hardcoded values, add fcl params

2e972c0

Merge tag 'v09_67_00' into feature/lynnt_lightcalorimetry

ab13d13

Version v09_67_00

added verbose + skip truth validation fcl

5a0893c

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

added verbose + skip truth validation fcl

bd8b760

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

initial commit of producer module

bf0b0cc

working version of producer module

8411be8

cleanup, new functions, fcl parameters:

52c18df

- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet

update output ttree, fix initialized/dummy ttree variables

a1df52b

- merge the two previous trees into one - match-type can now differentiate between event/slice level easily

Merge tag 'v09_89_01' into feature/lynnt_lightcalorimetry

d21b784

Version v09_89_01, patch release for SBN2024A

switch to correct namespace for photon model, cleanup

16ce241

update opdet efficiencies and simulation values

b791b51

make working version of fcl without the analyzer

543c337

update noise/non-linearity thresholds

2fc9be1

small cleanup

6b59f8e

Merge tag 'v09_93_01_02p02' into feature/lynnt_lightcalorimetry

07bdd70

Version v09_93_01_02p02

Merge tag 'v10_04_07' into feature/lynnt_lightcalorimetry

37a8831

Version v10_04_07

linyan-w reviewed Jan 28, 2026

View reviewed changes

ups/product_deps Show resolved Hide resolved

linyan-w approved these changes Jan 28, 2026

View reviewed changes

henrylay97 approved these changes Jan 29, 2026

View reviewed changes

lynnt20 added 5 commits January 29, 2026 10:33

add initial filename/timestamp info on the output art file

916b861

update LightCaloProducer to conditionally fill TTree and enhance logg…

2e219b7

…ing messages; avoid hardcoded TPC tick

Revert "Update to larsoft v10_14_02"

2bfc1df

This reverts commit 6ff86f1.

Add electron lifetime database support to LightCaloProducer and updat…

eb1a3a9

…e data fcl configuration

Merge tag 'v10_14_02_01' into feature/lynnt_lightcalorimetry

68d3ab0

Version v10_14_02_01

lynnt20 added 3 commits January 29, 2026 14:07

order matters for reco workflow includes!

81a67e8

update CMake dependences for TPC calibdb

d6b3270

fix some elifetime bugs

1a5e851

lynnt20 requested a review from sungbinoh January 29, 2026 20:38

move electron lifetime retrieval to avoid duplication during slice loop

da3ae91

henrylay97 approved these changes Jan 30, 2026

View reviewed changes

lynnt20 mentioned this pull request Feb 5, 2026

Light Calorimetry (Production) #911

Open

7 tasks

Conversation

lynnt20 commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links

Link(s) to docdb describing changes (optional)

Uh oh!

linyan-w commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

linyan-w left a comment

Choose a reason for hiding this comment

Uh oh!

lynnt20 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nathanielerowe commented Jan 29, 2026

Uh oh!

lynnt20 commented Jan 29, 2026

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

henrylay97 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

henrylay97 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

nathanielerowe commented Feb 5, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lynnt20 commented Nov 19, 2025 •

edited

Loading

linyan-w commented Jan 28, 2026 •

edited

Loading

lynnt20 commented Jan 28, 2026 •

edited

Loading