Skip to content

feat: Markdown export with YAML frontmatter#61

Closed
StevenLi-phoenix wants to merge 1 commit intomainfrom
pr/markdown-export-34
Closed

feat: Markdown export with YAML frontmatter#61
StevenLi-phoenix wants to merge 1 commit intomainfrom
pr/markdown-export-34

Conversation

@StevenLi-phoenix
Copy link
Copy Markdown
Owner

Summary

  • MarkdownExporter service with YAML frontmatter, timestamped/table formats
  • Export Markdown toolbar button (⌘E) in SessionDetailView
  • 12 unit tests

Closes #34

🤖 Generated with Claude Code

@claude
Copy link
Copy Markdown

claude bot commented Mar 28, 2026

✅ Claude Code Review: APPROVE

Clean, well-structured addition that follows project conventions — nonisolated enum service, proper YAML title escaping, correct main-thread NSSavePanel usage, and 12 unit tests covering all pure-logic paths.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Auto-merge skipped: Tests, unchecked checkboxes, merge conflicts, or merge step failed. Manual review required.

@StevenLi-phoenix
Copy link
Copy Markdown
Owner Author

Notes — Markdown Export with YAML Frontmatter (#34)

APPROVED,auto-merge 跳过。

补充建议

  1. Frontmatter 字段扩展:除了基础字段(title, date, duration),建议添加:

    tags: [产品讨论, 定价]  # 配合 #76 auto-tagging
    speakers: [张三, 李四]   # 配合 #79 diarization
    action_items: 3          # 配合 #57
    word_count: 1234         # 配合 #71
  2. Obsidian/Notion 兼容:YAML frontmatter 是 Obsidian 的标准格式。确保日期格式为 ISO 8601(2026-03-28T10:00:00+08:00),tags 为数组格式。

  3. 自动导出:PR feat: auto-export pipeline for post-recording automation #86 (Auto-export) 的 "write file" action 可以直接调用 MarkdownExporter——这两个 PR 是天然配对。

  4. 模板系统:未来与 会议模板与工作流预设 (Meeting Templates & Workflow Presets) #97 (Meeting Templates) 集成——不同模板可以定义不同的 Markdown 导出格式。

请检查 checkboxes。

@StevenLi-phoenix
Copy link
Copy Markdown
Owner Author

Auto-Merge 被阻塞

Build 和 Review 都通过了,但 auto-merge 步骤失败。

原因分析: 今天 main 分支收到了大量直接提交(karaoke sync, pin/favorite, trash, hotkey, auto-tagging 等 11 个功能),导致这些 PR 分支与 main 产生冲突。

建议: 鉴于 #34 (Markdown export) 已经直接在 main 上实现(commit f448a81),这个 PR 可能可以关闭。如果有增量改动(如独有测试用例),建议 rebase onto main 后只保留增量部分。

@StevenLi-phoenix
Copy link
Copy Markdown
Owner Author

Closing: Markdown export (#34) already merged to main via commit 38432d9. This PR is superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown 导出含 YAML Frontmatter (Markdown Export)

1 participant