pdn: only consider routing layer obstructions for grid obstructions#9520
Open
gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
pdn: only consider routing layer obstructions for grid obstructions#9520gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly modifies the via generation logic to ignore grid obstructions on non-routing layers (cut layers). This change allows via generation in areas where macros have via blockages, addressing the issue where followpins could ignore these blockages but the vias connecting to them could not. The logic is sound and includes a performance improvement by adding a break once a via is found to be obstructed. However, the new integration test macros_cells_halo_blocking is missing its golden DEF file (.defok), which will cause CI failures. Additionally, the BUILD file needs to be updated to include this golden file in the test's resource map.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This should largely be a no-op for most PDKs.