Skip to content

Comments

pdn: only consider routing layer obstructions for grid obstructions#9520

Open
gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
gadfort:pdn-ignore-cut
Open

pdn: only consider routing layer obstructions for grid obstructions#9520
gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
gadfort:pdn-ignore-cut

Conversation

@gadfort
Copy link
Collaborator

@gadfort gadfort commented Feb 22, 2026

Changes:

  • only consider routing layer obstructions from macro obstructions during via generation.
  • Since the followpins are allowed to ignore the grid obstructions without this, the vias cannot be built in M1/M2 via arrays if the macro contains via blockages.
    This should largely be a no-op for most PDKs.

Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
@gadfort gadfort requested a review from maliberty February 22, 2026 19:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly modifies the via generation logic to ignore grid obstructions on non-routing layers (cut layers). This change allows via generation in areas where macros have via blockages, addressing the issue where followpins could ignore these blockages but the vias connecting to them could not. The logic is sound and includes a performance improvement by adding a break once a via is found to be obstructed. However, the new integration test macros_cells_halo_blocking is missing its golden DEF file (.defok), which will cause CI failures. Additionally, the BUILD file needs to be updated to include this golden file in the test's resource map.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant