tweak(worldbuilder): Remove EULA code and data

[Caball009]

Currently every launch of the (Zero Hour) World Builder requires accepting the end-user license agreement. This is unnecessarily inconvenient. The Steam version of the WB doesn't show this window, and it was pointed out to me that we're not required to show this window under GPL v3.0. This PR should remove all code and data relating to the EULA window.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

Removes the EULA dialog code and data from the WorldBuilder tool in both Generals and GeneralsMD (Zero Hour). The EA Tools End User License window was shown on every launch, which is unnecessary under the project's GPL v3.0 license (and was already absent in the Steam version). The removal is clean and consistent across both codebases.

• Deleted EulaDialog.cpp and euladialog.h source files from both Generals and GeneralsMD
• Removed EULA dialog resource definitions, design guidelines, and string table entries from both WorldBuilder.rc files
• Removed EULA include and modal dialog invocation from CWorldBuilderApp::InitInstance() in both WorldBuilder.cpp files
• Updated both CMakeLists.txt files to remove the deleted source files from the build

Confidence Score: 5/5

• This PR is safe to merge — it cleanly removes dead EULA code with no functional side effects.
• The changes are purely deletions of self-contained EULA dialog code. No new code is introduced. The removed code was a standalone feature (modal dialog on startup) with no dependencies from other parts of the application. All references to the EULA dialog have been removed from source files, build files, and resource files in both Generals and GeneralsMD directories. No logic errors or regressions are possible from this removal.
• No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/Tools/WorldBuilder/CMakeLists.txt	Removed EulaDialog.cpp and euladialog.h from the build source list. Straightforward removal.
Generals/Code/Tools/WorldBuilder/res/WorldBuilder.rc	Removed EULA dialog definition, EULA design guidelines, and EULA string table entries. All removals are clean.
Generals/Code/Tools/WorldBuilder/src/WorldBuilder.cpp	Removed #include "euladialog.h" and the EULA dialog modal check in InitInstance(). Application now launches directly without EULA prompt.
GeneralsMD/Code/Tools/WorldBuilder/CMakeLists.txt	Removed EulaDialog.cpp and euladialog.h from the build source list. Mirrors the Generals change.
GeneralsMD/Code/Tools/WorldBuilder/res/WorldBuilder.rc	Removed EULA dialog definition, EULA design guidelines, and EULA string table entries. All removals are clean.
GeneralsMD/Code/Tools/WorldBuilder/src/WorldBuilder.cpp	Removed #include "euladialog.h" and the EULA dialog modal check in InitInstance(). Application now launches directly without EULA prompt.

Flowchart

flowchart TD
    A["CWorldBuilderApp::InitInstance()"] -->|Before PR| B["EulaDialog::DoModal()"]
    B -->|IDCANCEL| C["return FALSE\n(App exits)"]
    B -->|IDOK| D["Continue initialization\n(SetUnhandledExceptionFilter, etc.)"]
    A -->|After PR| D
    D --> E["SplashScreen / Main Window"]

Loading

_{Last reviewed commit: a295426}

[greptile-apps]

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}