Open
Conversation
added 2 commits
December 20, 2025 01:13
Contributor
Author
dphaldes
reviewed
Dec 21, 2025
Comment on lines
+17
to
+21
| public MixinLivingEntity(EntityType<?> p_19870_, Level p_19871_) { | ||
| super(p_19870_, p_19871_); | ||
| throw new IllegalStateException("Instantiated MixinLivingEntity"); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Why is this needed ? It's an abstract class and won't be instantiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure it was necessary in the end since at least part of the issue was not having it reobfuscate the jarJar file, but:
this is because A) the shadowed method is already public and B) https://wiki.fabricmc.net/tutorial:mixin_tips suggests extending the parent class of the target in such cases
and sit in a dusty corner where it'll be ignoredBased on #2129 with permission of the author