Make table subtyping invariant#8489
Open
stevenfontanella wants to merge 1 commit intoglobal-validationfrom
Open
Make table subtyping invariant#8489stevenfontanella wants to merge 1 commit intoglobal-validationfrom
stevenfontanella wants to merge 1 commit intoglobal-validationfrom
Conversation
stevenfontanella
force-pushed
the
table-invariant
branch
from
56e20a9 to
9a27ffe
Compare
stevenfontanella
force-pushed
the
global-validation
branch
from
ba2c167 to
6b63ad6
Compare
stevenfontanella
force-pushed
the
table-invariant
branch
from
9a27ffe to
f7a472e
Compare
tlively
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table subtyping for imports should be invariant according to the spec:
. This makes sense because the exporter might write the supertype and the importer may later try to read a subtype which would be wrong.
The other copy of
linking.wastis no longer relevant and doesn't pass with these changes. Our copy: link, upstream test: link (see line 410 which differs from our copy of the test).Part of #8261.