Make table subtyping invariant

scripts/test/shared.py

@@ -387,9 +387,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
     # Requires us to write our own floating point parser
     'const.wast',
 
-    # Unlinkable module accepted
-    'linking.wast',
-
     # Invalid module accepted
     'unreached-invalid.wast',
 
@@ -423,7 +420,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
     'if.wast',      # Requires more precise unreachable validation
     'imports.wast',  # Requires fixing handling of mutation to imported globals
     'proposals/threads/imports.wast',  # Missing memory type validation on instantiation
-    'linking.wast',  # Incorrectly allows covariant subtyping for table imports
     'proposals/threads/memory.wast',  # Missing memory type validation on instantiation
     'annotations.wast',  # String annotations IDs should be allowed
     'instance.wast',  # Requires support for table default elements

src/ir/runtime-table.h

@@ -47,8 +47,8 @@ class RuntimeTable {
   // be imported with the definition of `other`
   virtual bool isSubType(const Table& other) {
     return tableDefinition.addressType == other.addressType &&
-           Type::isSubType(tableDefinition.type, other.type) &&
-           size() >= other.initial && tableDefinition.max <= other.max;
+           tableDefinition.type == other.type && size() >= other.initial &&
+           tableDefinition.max <= other.max;
   }
 
   const Table* getDefinition() const { return &tableDefinition; }