feat: add url_type to click_url assets and remove click_tracker#47
Merged
BaiyuScope3 merged 2 commits intomainfrom Feb 12, 2026
Merged
feat: add url_type to click_url assets and remove click_tracker#47BaiyuScope3 merged 2 commits intomainfrom
BaiyuScope3 merged 2 commits intomainfrom
Conversation
- Add url_type="clickthrough" to all click_url assets for consistency - Create create_click_url_asset() helper function - Remove click_tracker asset from all formats (redundant with click_url) URL assets now have consistent url_type values: - click_url: "clickthrough" - impression_tracker: "tracker_pixel" Co-authored-by: Cursor <cursoragent@cursor.com>
BaiyuScope3
commented
Feb 12, 2026
BaiyuScope3
commented
Feb 12, 2026
The click_tracker asset was removed, so these tests are no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com>
BaiyuScope3
commented
Feb 12, 2026
bokelley
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All click_url asset missing
url_type="clickthrough, without this, the sales agent will need to fallback on a list of hard coded asset ids which is not really reliable to know which url to be used as click, which url should used as tracker etc.url_type="clickthrough"to allclick_urlassets for consistency with other URL assetscreate_click_url_asset()helper function to standardize click URL creationclick_trackerasset from all formats (redundant), clickthough url will be enough for trackingURL assets now have consistent
url_typevalues:url_typeclick_urlclickthroughimpression_trackertracker_pixelTest plan
list_creative_formatsreturnsurl_type: "clickthrough"for click_url assetsMade with Cursor