Skip to content

fix: IOEXT-1713 - change use of node-fetch to @adobe/aio-lib-core-networking#32

Merged
shazron merged 1 commit intomasterfrom
story/IOEXT-1713
Nov 12, 2025
Merged

fix: IOEXT-1713 - change use of node-fetch to @adobe/aio-lib-core-networking#32
shazron merged 1 commit intomasterfrom
story/IOEXT-1713

Conversation

@shazron
Copy link
Member

@shazron shazron commented Nov 11, 2025

Description

Fixes SSL CONNECT proxy issues since the current implementation does not use a proxy if available.

How Has This Been Tested?

Tested by:

  • local link this branch plugin via aio plugins link .
  • make sure to run: aio telemetry on
  • run HTTPS_PROXY=http://localhost:8888 aio app add action in an AB app, then observe the connections in Charles Web Proxy (they should all be CONNECT, not GET)
  • see that dcs.adobedc.net connects to the proxy via CONNECT

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron shazron merged commit cb4d2ff into master Nov 12, 2025
9 checks passed
@shazron shazron deleted the story/IOEXT-1713 branch November 12, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants