feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean#1829
feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean#1829jbonofre wants to merge 1 commit intoapache:mainfrom
Conversation
jbonofre
changed the title
jbonofre
force-pushed
the
AMQ-network-connector-mbean-uri
branch
from
4eef489 to
1b25c26
Compare
|
|
||
| @Override | ||
| public URI getUri() { | ||
| return remoteURI; |
There was a problem hiding this comment.
I know it's redundant with getRemoteURI() here, but it's for consistency.
I'm fine to use getRemoveURI() everywhere if it makes more sense.
There was a problem hiding this comment.
It's a bit weird indeed. Maybe add a small comment for us, so no one goes in one month from now and says, it's duplicate I'll remove it
There was a problem hiding this comment.
I think it'd make more sense to make MulticastNetworkConnector have a 'getUri()' method instead.
I'm pretty against doing any field name mapping at the admin view b/c it is miscommunicating to users
There was a problem hiding this comment.
OK, I was hesitating. Thanks for your inputs, let's use getRemoteURI() then.
|
|
||
| @Override | ||
| public URI getUri() { | ||
| return remoteURI; |
There was a problem hiding this comment.
It's a bit weird indeed. Maybe add a small comment for us, so no one goes in one month from now and says, it's duplicate I'll remove it
…Bean Add getUri() and getLocalUri() attributes to NetworkConnectorViewMBean so that the network connector URI is visible via JMX. Add abstract getUri() to NetworkConnector base class and implement it in MulticastNetworkConnector.
jbonofre
force-pushed
the
AMQ-network-connector-mbean-uri
branch
from
1b25c26 to
957eabf
Compare
3 participants
Add getUri() and getLocalUri() attributes to NetworkConnectorViewMBean so that the network connector URI is visible via JMX. Add abstract getUri() to NetworkConnector base class and implement it in MulticastNetworkConnector.