Skip to content

feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbonofre wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions activemq-broker/src/main/java/org/apache/activemq/broker/jmx/NetworkConnectorView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
package org.apache.activemq.broker.jmx;

import java.net.URISyntaxException;

import org.apache.activemq.network.NetworkConnector;

public class NetworkConnectorView implements NetworkConnectorViewMBean {
Expand All @@ -37,6 +39,20 @@ public void stop() throws Exception {
connector.stop();
}

@Override
public String getUri() {
return connector.getUri() != null ? connector.getUri().toString() : "";
}

@Override
public String getLocalUri() {
try {
return connector.getLocalUri() != null ? connector.getLocalUri().toString() : "";
} catch (URISyntaxException e) {
return "";
}
}

@Override
public String getName() {
return connector.getName();
Expand Down
4 changes: 4 additions & 0 deletions activemq-broker/src/main/java/org/apache/activemq/broker/jmx/NetworkConnectorViewMBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@

public interface NetworkConnectorViewMBean extends Service {

String getUri();

String getLocalUri();

String getName();

int getMessageTTL();
Expand Down
5 changes: 5 additions & 0 deletions activemq-broker/src/main/java/org/apache/activemq/network/MulticastNetworkConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ public void setRemoteTransport(Transport remoteTransport) {
this.remoteTransport = remoteTransport;
}

@Override
public URI getUri() {
return remoteURI;
Copy link
Copy Markdown
Member Author

@jbonofre jbonofre Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's redundant with getRemoteURI() here, but it's for consistency.

I'm fine to use getRemoveURI() everywhere if it makes more sense.

Copy link
Copy Markdown
Contributor

@jeanouii jeanouii Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird indeed. Maybe add a small comment for us, so no one goes in one month from now and says, it's duplicate I'll remove it

Copy link
Copy Markdown
Contributor

@mattrpav mattrpav Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd make more sense to make MulticastNetworkConnector have a 'getUri()' method instead.

I'm pretty against doing any field name mapping at the admin view b/c it is miscommunicating to users

Copy link
Copy Markdown
Member Author

@jbonofre jbonofre Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was hesitating. Thanks for your inputs, let's use getRemoteURI() then.

}

public URI getRemoteURI() {
return remoteURI;
}
Expand Down
2 changes: 2 additions & 0 deletions activemq-broker/src/main/java/org/apache/activemq/network/NetworkConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ public NetworkConnector(URI localURI) {
this.localURI = localURI;
}

public abstract URI getUri();

public URI getLocalUri() throws URISyntaxException {
return localURI;
}
Expand Down
2 changes: 2 additions & 0 deletions activemq-unit-tests/src/test/java/org/apache/activemq/jmx/JmxCreateNCTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,7 @@ public void testBridgeRegistration() throws Exception {

assertNotNull(nc);
assertEquals("NC", nc.getName());
assertEquals("static:(tcp://localhost:61617)", nc.getUri());
assertNotNull(nc.getLocalUri());
}
}
Loading