fix: ensure discard_max_bytes is set to 0 only for existing block devices#4745
Open
nodece wants to merge 1 commit intoapache:masterfrom
Open
fix: ensure discard_max_bytes is set to 0 only for existing block devices#4745nodece wants to merge 1 commit intoapache:masterfrom
nodece wants to merge 1 commit intoapache:masterfrom
Conversation
nodece
force-pushed
the
fix-discard_max_bytes
branch
from
340c9bc to
5f30f34
Compare
nodece
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In CI environments, the following error was observed when attempting to disable discard:
This happens because the script assumes block devices follow the
sd*naming convention, which is not always true (e.g., NVMe or virtual disks). As a result, the glob does not match any files and causes the step to fail.Modifications
/sys/block/sd*/queue/discard_max_byteswith/sys/block/*/queue/discard_max_bytesto support all block device types-f) before applyingteeto avoid errors when the file is not present