Skip to content

fix: ensure discard_max_bytes is set to 0 only for existing block devices #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nodece wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix: ensure discard_max_bytes is set to 0 only for existing block devices #4745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/actions/tune-runner-vm/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,10 @@ runs:
sudo mount -o remount,nodiscard,commit=999999,barrier=0 /mnt || true
# disable discard/trim at device level since remount with nodiscard doesn't seem to be effective
# https://www.spinics.net/lists/linux-ide/msg52562.html
for i in /sys/block/sd*/queue/discard_max_bytes; do
echo 0 | sudo tee $i
for i in /sys/block/*/queue/discard_max_bytes; do
if [ -f "$i" ]; then
echo 0 | sudo tee "$i"
fi
done
# disable any background jobs that run SSD discard/trim
sudo systemctl disable fstrim.timer || true
Expand Down
Loading