Fix generator for java.time.Duration default values#1736
Merged
Conversation
The auto-configuration generator assumed duration-type properties always use long/int Java types. Properties with javaType java.time.Duration (e.g. embeddingStoreSchemaRegistrationTimeout from CAMEL-23255) got a bare int literal as initializer, causing a compilation error in the generated configuration class. Generate Duration.ofMillis(...) when the javaType is java.time.Duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
long/intJava typesjavaType: "java.time.Duration"(e.g.embeddingStoreSchemaRegistrationTimeoutfrom CAMEL-23255) got a bareintliteral as initializer, causingincompatible types: int cannot be converted to java.time.Durationin the generatedInfinispanRemoteComponentConfiguration.javaDuration.ofMillis(...)when the javaType isjava.time.DurationContext
Both Camel-Spring-Boot Daily/main (build #46) and Camel-Spring-Boot Daily (ppc64le)/main (build #1460) fail with this compilation error on
camel-infinispan-starter.Test plan
camel-infinispan-startercompiles with regenerated code (was failing before)camel-infinispan-cluster-service-startercompilesDuration.ofMillis(60000)initializer with proper import