Skip to content

Fix generator for java.time.Duration default values #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Croway merged 1 commit into from
Mar 31, 2026
Merged

Fix generator for java.time.Duration default values #1736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...ugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,11 +743,15 @@ private void createComponentConfigurationSource(String packageName, ComponentMod
prop.getField().setStringInitializer(option.getDefaultValue().toString());
} else if ("duration".equals(option.getType())) {
String value = convertDurationToMills(option.getDefaultValue().toString());
// duration is either long or int java type
if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
if ("java.time.Duration".equals(option.getJavaType())) {
prop.getField().setLiteralInitializer("Duration.ofMillis(" + value + ")");
javaClass.addImport("java.time.Duration");
} else if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
value = value + "L";
prop.getField().setLiteralInitializer(value);
} else {
prop.getField().setLiteralInitializer(value);
}
prop.getField().setLiteralInitializer(value);
} else if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
// the value should be a Long number
String value = option.getDefaultValue() + "L";
Expand Down
Loading