Few UI fixes and details improvements by harikrishna-patnala · Pull Request #7434 · apache/cloudstack

harikrishna-patnala · 2023-04-14T11:54:09Z

Description

This PR fixes the following items:

Fixed the buttons at the top of the UI which are not aligned to cented/bottom/same size (Refresh / Metrics / Projects – also the Instances and the filter box “all”) – consider making them same width, or improve in
The same is true for all dialogs – Volumes, Snapshots, Networks, etc.
Removed project UI icon
Edit, delete, restart network icons are greyed out if the user does not have the permission
Added a description while creation of Network during Instance deployment time
Added doc help link and form changes while creating Stickness of LB

I've added a doc PR to explain the options in detail here apache/cloudstack-documentation#312

“generate keys” button/popup improvement

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

harikrishna-patnala · 2023-04-14T12:12:38Z

@blueorangutan ui

blueorangutan · 2023-04-14T12:13:04Z

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-04-14T12:27:33Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7434 (QA-JID-83)

codecov · 2023-04-14T13:10:58Z

Codecov Report

Merging #7434 (eab0ac7) into main (8e7c1f7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7434      +/-   ##
============================================
- Coverage     12.72%   12.72%   -0.01%     
  Complexity     8703     8703              
============================================
  Files          2727     2727              
  Lines        256493   256493              
  Branches      39988    39988              
============================================
- Hits          32627    32626       -1     
- Misses       219716   219720       +4     
+ Partials       4150     4147       -3

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shwstppr · 2023-04-17T11:23:53Z

@blueorangutan ui

blueorangutan · 2023-04-17T11:25:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-04-17T11:38:30Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7434 (QA-JID-85)

sonarqubecloud · 2023-04-17T11:42:02Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

shwstppr

Code changes LGTM

harikrishna-patnala · 2023-04-18T07:46:38Z

@blueorangutan package

blueorangutan · 2023-04-18T07:48:03Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-04-18T08:42:55Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5924

harikrishna-patnala · 2023-04-18T08:45:16Z

@blueorangutan package

blueorangutan · 2023-04-18T08:46:03Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-04-18T09:21:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5925

yadvr · 2023-04-21T04:54:20Z

@blueorangutan ui

blueorangutan · 2023-04-21T04:55:04Z

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-04-21T05:08:41Z

UI build failed: ✖️
(SL-JID-93)

yadvr

LGTM, suggest to also look at the nav bar width issue and the blocks issue in the infra page (for admins). Didn't test it completely.

borisstoyanov · 2023-04-21T08:59:44Z

@blueorangutan ui

blueorangutan · 2023-04-21T09:00:04Z

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

borisstoyanov · 2023-04-21T11:45:32Z

@blueorangutan test keepEnv

blueorangutan · 2023-04-21T11:46:03Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

harikrishna-patnala · 2023-04-26T10:29:43Z

@blueorangutan package

blueorangutan · 2023-04-26T11:10:15Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5980

borisstoyanov · 2023-04-26T11:11:11Z

@blueorangutan test keepEnv

blueorangutan · 2023-04-26T11:12:03Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-04-26T23:36:52Z

Trillian test result (tid-6471)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43312 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7434-t6471-kvm-centos7.zip
Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

harikrishna-patnala · 2023-04-28T09:57:12Z

@blueorangutan package

blueorangutan · 2023-04-28T09:58:03Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-04-28T10:41:04Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5997

borisstoyanov · 2023-04-28T10:41:48Z

@blueorangutan ui

blueorangutan · 2023-04-28T10:42:04Z

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-04-28T10:47:04Z

UI build failed: ✖️
(SL-JID-97)

borisstoyanov

LGTM

yadvr · 2023-05-02T11:36:58Z

LGTM, merging based on @borisstoyanov 's testing. Thanks @harikrishna-patnala

weizhouapache · 2023-05-05T09:30:18Z

@harikrishna-patnala @rohityadavcloud
do we need this to backport to 4.18 ?

boring-cyborg bot added component:storage component:UI labels Apr 14, 2023

harikrishna-patnala force-pushed the UIFixesAndDetailsImprovements branch from f384f15 to b1e056b Compare April 14, 2023 12:10

boring-cyborg bot added the component:api label Apr 17, 2023

shwstppr approved these changes Apr 17, 2023

View reviewed changes

shwstppr added this to the 4.19.0.0 milestone Apr 19, 2023

yadvr approved these changes Apr 21, 2023

View reviewed changes

yadvr added the status:needs-testing label Apr 21, 2023

harikrishna-patnala added 10 commits April 28, 2023 12:57

Better hover label and message for generate API/secret keys form

2a58951

Added a message to select network during instance deployment

7fce0fe

Removed project icon in dashboard listing

27c39e0

Disable network operations for the user who does not have permission

49bb748

UI allignments

a1a7b6e

added document help for sticky policy secion under load balancer

13b55cf

Added tooltips and some form layout changes

ffcdb7b

donot display options to configure when stickypolicy is none

d50b86a

Network selection message allignment

8bf8367

Fixed the grid view to be uniform in infra summary page

eab0ac7

harikrishna-patnala force-pushed the UIFixesAndDetailsImprovements branch from 22dd4ae to eab0ac7 Compare April 28, 2023 09:56

borisstoyanov approved these changes Apr 28, 2023

View reviewed changes

yadvr merged commit b280370 into apache:main May 2, 2023

yadvr deleted the UIFixesAndDetailsImprovements branch May 2, 2023 11:37

weizhouapache added the release: backport-4.18 label May 5, 2023

harikrishna-patnala mentioned this pull request Jul 13, 2023

Added details to the stickiness policy under load balancing apache/cloudstack-documentation#312

Merged

harikrishna-patnala mentioned this pull request Oct 9, 2023

Fix allignment on layout on right panel #8060

Merged

13 tasks

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

harikrishna-patnala commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

harikrishna-patnala commented Apr 14, 2023

Uh oh!

blueorangutan commented Apr 14, 2023

Uh oh!

blueorangutan commented Apr 14, 2023

Uh oh!

codecov bot commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Apr 17, 2023

Uh oh!

blueorangutan commented Apr 17, 2023

Uh oh!

blueorangutan commented Apr 17, 2023

Uh oh!

sonarqubecloud bot commented Apr 17, 2023

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Apr 18, 2023

Uh oh!

blueorangutan commented Apr 18, 2023

Uh oh!

blueorangutan commented Apr 18, 2023

Uh oh!

harikrishna-patnala commented Apr 18, 2023

Uh oh!

blueorangutan commented Apr 18, 2023

Uh oh!

blueorangutan commented Apr 18, 2023

Uh oh!

yadvr commented Apr 21, 2023

Uh oh!

blueorangutan commented Apr 21, 2023

Uh oh!

blueorangutan commented Apr 21, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Apr 21, 2023

Uh oh!

blueorangutan commented Apr 21, 2023

Uh oh!

borisstoyanov commented Apr 21, 2023

Uh oh!

blueorangutan commented Apr 21, 2023

Uh oh!

harikrishna-patnala commented Apr 26, 2023

Uh oh!

blueorangutan commented Apr 26, 2023

Uh oh!

borisstoyanov commented Apr 26, 2023

Uh oh!

blueorangutan commented Apr 26, 2023

Uh oh!

blueorangutan commented Apr 26, 2023

Uh oh!

harikrishna-patnala commented Apr 28, 2023

Uh oh!

blueorangutan commented Apr 28, 2023

Uh oh!

blueorangutan commented Apr 28, 2023

Uh oh!

borisstoyanov commented Apr 28, 2023

Uh oh!

blueorangutan commented Apr 28, 2023

harikrishna-patnala commented Apr 14, 2023 •

edited

Loading

codecov bot commented Apr 14, 2023 •

edited

Loading