server,api,ui: host auto-select for migrateVirtualMachineWithVolume

[shwstppr]

Description

Fixes #6773

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested with migration of a VM with 2 KVM hosts with local storage,

auto-select-vm-local-storage-migration.mp4

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6138

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #7554 (175367b) into main (c9b103c) will increase coverage by 0.01%.
The diff coverage is 53.57%.

@@             Coverage Diff              @@
##               main    #7554      +/-   ##
============================================
+ Coverage     12.95%   12.97%   +0.01%     
- Complexity     8986     9012      +26     
============================================
  Files          2728     2728              
  Lines        256647   256678      +31     
  Branches      40024    40031       +7     
============================================
+ Hits          33257    33308      +51     
+ Misses       219210   219187      -23     
- Partials       4180     4183       +3     

Impacted Files	Coverage Δ
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	8.06% <53.57%> (+0.71%)	⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6158

[shwstppr]

@blueorangutan test matrix

[blueorangutan]

@shwstppr a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6601)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6601-xenserver-71.zip
Smoke tests completed. 85 look OK, 1 have errors, 24 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	Error	3973.53	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Error	4067.10	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	3721.61	test_kubernetes_clusters.py
all_test_safe_shutdown	Skipped	---	test_safe_shutdown.py
all_test_metrics_api	Skipped	---	test_metrics_api.py
all_test_outofbandmanagement	Skipped	---	test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin	Skipped	---	test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy	Skipped	---	test_routers_iptables_default_policy.py
all_test_secondary_storage	Skipped	---	test_secondary_storage.py
all_test_service_offerings	Skipped	---	test_service_offerings.py
all_test_storage_policy	Skipped	---	test_storage_policy.py
all_test_templates	Skipped	---	test_templates.py
all_test_update_security_group	Skipped	---	test_update_security_group.py
all_test_usage_events	Skipped	---	test_usage_events.py
all_test_vm_autoscaling	Skipped	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	Skipped	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	Skipped	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	Skipped	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm	Skipped	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	Skipped	---	test_vm_snapshots.py
all_test_volumes	Skipped	---	test_volumes.py
all_test_vpc_ipv6	Skipped	---	test_vpc_ipv6.py
all_test_vpc_redundant	Skipped	---	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py
all_test_hostha_kvm	Skipped	---	test_hostha_kvm.py

[blueorangutan]

[SF] Trillian test result (tid-6602)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 55435 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6602-vmware-67u3.zip
Smoke tests completed. 108 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	Error	21.79	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	3602.03	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	4.40	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	12.56	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	3603.08	test_vm_deployment_planner.py
test_09_expunge_vm	Failure	424.57	test_vm_life_cycle.py

[blueorangutan]

[SF] Trillian test result (tid-6603)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59376 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6603-kvm-centos7.zip
Smoke tests completed. 108 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Error	4034.28	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	3689.25	test_kubernetes_clusters.py
test_hostha_enable_ha_when_host_disabled	Error	0.72	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Error	301.80	test_hostha_kvm.py

[DaanHoogland]

@shwstppr do you need eyes on this?

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6075

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6109

[yadvr]

@blueorangutan LLtest

[blueorangutan]

@rohityadavcloud a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[LL]Trillian test result (tid-6595)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42773 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6595-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	Failure	422.03	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	422.04	test_vpc_redundant.py

[shwstppr]

@blueorangutan test matrix

[blueorangutan]

@shwstppr a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6721)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42915 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6721-vmware-67u3.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-6722)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43591 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6722-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-6720)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47400 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7554-t6720-xenserver-71.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	Error	1.23	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	1332.92	test_vm_deployment_planner.py

[DaanHoogland]

tested on KVM and checked if the ROOT volume would end up on the new host's local storage.

[DaanHoogland]

@weizhouapache do we need this on 4.18? (cc @shwstppr )

[weizhouapache]

@weizhouapache do we need this on 4.18? (cc @shwstppr )

@DaanHoogland @shwstppr
good to have it in 4.18.1.0
however, it is up to the author @shwstppr

[shwstppr]

@weizhouapache changes in this PR adds a new API request param which is why I based it on main.
If you think that would be okay for 4.18.1, I can update it to Target 4.18 branch

[DaanHoogland]

@weizhouapache changes in this PR adds a new API request param which is why I based it on main. If you think that would be okay for 4.18.1, I can update it to Target 4.18 branch

A corner case @shwstppr , it is not incompatible and seems like a small enhancement. Whatever you say.