Fixup updateSnapshotInfo failure due to forward merging#8150
Merged
shwstppr merged 2 commits intoapache:mainfrom Oct 26, 2023
Merged
Fixup updateSnapshotInfo failure due to forward merging#8150shwstppr merged 2 commits intoapache:mainfrom
shwstppr merged 2 commits intoapache:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8150 +/- ##
============================================
+ Coverage 4.78% 29.25% +24.46%
- Complexity 0 30760 +30760
============================================
Files 346 5127 +4781
Lines 26150 361479 +335329
Branches 4497 52802 +48305
============================================
+ Hits 1252 105755 +104503
- Misses 24763 241203 +216440
- Partials 135 14521 +14386
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4780 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shwstppr
reviewed
Oct 26, 2023
| SnapshotService snapshotService; | ||
| @Mock | ||
| SnapshotDataFactory snapshotDataFactory; | ||
| SnapshotDataFactory snapshotFactory; |
Member
Author
There was a problem hiding this comment.
Yes. Getting a null pointer exception.
https://github.com/apache/cloudstack/actions/runs/6651356366/job/18073228134
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
shwstppr
added a commit
to shapeblue/cloudstack
that referenced
this pull request
May 7, 2024
Fixes apache#8150 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
13 tasks
weizhouapache
pushed a commit
that referenced
this pull request
May 8, 2024
Fixes #8150 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
my-code-AL
pushed a commit
to my-code-AL/cloudstack
that referenced
this pull request
May 31, 2024
Fixes apache#8150 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?