branch-4.0: [Bug](function) add ndv decimalv2 support #61546#61577
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [Bug](function) add ndv decimalv2 support #61546#61577github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
This pull request focuses on improving support for the `DECIMALV2` data type in aggregate functions and updating related regression tests to ensure correctness. The most important changes are grouped below: ### Aggregate Function Support * Added `TYPE_DECIMALV2` to the supported types for the `approx_count_distinct` aggregate function in `aggregate_function_approx_count_distinct.cpp`, enabling this function to work with `DECIMALV2` columns. ### Regression Test Enhancements * Updated the output in `test_decimalv2.out` to reflect higher precision for `DECIMALV2` values, showing results with more decimal places to match the new behavior. * Added a new test case in `test_decimalv2.groovy` to verify the correct behavior of the `ndv` (number of distinct values) aggregate function on `DECIMALV2` columns.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61546