Skip to content

branch-4.0: [Bug](function) add ndv decimalv2 support #61546 #61577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
+36 −30
Open

branch-4.0: [Bug](function) add ndv decimalv2 support #61546 #61577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions be/src/vec/aggregate_functions/aggregate_function_approx_count_distinct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ AggregateFunctionPtr create_aggregate_function_approx_count_distinct(
const bool result_is_nullable, const AggregateFunctionAttr& attr) {
return creator_with_type_list<
TYPE_BOOLEAN, TYPE_TINYINT, TYPE_SMALLINT, TYPE_INT, TYPE_BIGINT, TYPE_LARGEINT,
TYPE_FLOAT, TYPE_DOUBLE, TYPE_DECIMAL32, TYPE_DECIMAL64, TYPE_DECIMAL128I,
TYPE_DECIMAL256, TYPE_VARCHAR, TYPE_DATEV2, TYPE_DATETIMEV2, TYPE_IPV4, TYPE_IPV6,
TYPE_FLOAT, TYPE_DOUBLE, TYPE_DECIMALV2, TYPE_DECIMAL32, TYPE_DECIMAL64,
TYPE_DECIMAL128I, TYPE_DECIMAL256, TYPE_VARCHAR, TYPE_DATEV2, TYPE_DATETIMEV2,
TYPE_IPV4, TYPE_IPV6,
TYPE_TIMESTAMPTZ>::create<AggregateFunctionApproxCountDistinct>(argument_types,
result_is_nullable,
attr);
Expand Down
59 changes: 31 additions & 28 deletions regression-test/data/nereids_p0/datatype/test_decimalv2.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,55 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !sql1 --
1.230
1.230000000

-- !sql2 --
1.230

-- !sql1 --
1 1.230
2 2.340
3 3.450
1 1.230000000
2 2.340000000
3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !sql2 --
1 1.230 1 1.230
2 2.340 2 2.340
3 3.450 3 3.450
1 1.230000000 1 1.230000000
2 2.340000000 2 2.340000000
3 3.450000000 3 3.450000000

-- !test --
3

2 changes: 2 additions & 0 deletions regression-test/suites/nereids_p0/datatype/test_decimalv2.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,7 @@ suite("test_decimalv2") {
sql " set runtime_filter_type = 8; "
qt_sql2 "select * from ${tbName} a, ${tbName} b WHERE a.c2 = b.c2 ORDER BY a.c0"

qt_test "select ndv(c2) from ${tbName}; "

sql "DROP TABLE ${tbName}"
}
Loading