[cleanup](build) Replace #include exec_env.h with forward declaration in 19 headers#61582
Open
shuke987 wants to merge 1 commit intoapache:masterfrom
Open
[cleanup](build) Replace #include exec_env.h with forward declaration in 19 headers#61582shuke987 wants to merge 1 commit intoapache:masterfrom
shuke987 wants to merge 1 commit intoapache:masterfrom
Conversation
… in 19 headers Remove unused #include "runtime/exec_env.h" from 10 header files and replace with forward declaration class ExecEnv in 9 header files that only use ExecEnv*. Move the full include to corresponding .cpp files where needed. Verified with full BE compilation on build server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "runtime/exec_env.h"from 10 header files that don't reference ExecEnvclass ExecEnv;forward declaration in 9 header files that only useExecEnv*pointerclass Thread;forward declaration inworkload_sched_policy_mgr.h(was transitively included via exec_env.h)Files changed (24 files)
Headers - include removed (unused):
exec/operator/aggregation_sink_operator.hexec/scan/scanner.hexec/sink/load_stream_map_pool.hexec/sink/load_stream_stub.hexec/sink/writer/vtablet_writer.hexec/sink/writer/vtablet_writer_v2.hload/group_commit/wal/wal_info.hstorage/metadata_adder.hstorage/rowset/rowset_writer_context.hstorage/segment/page_handle.hHeaders - replaced with forward declaration:
agent/workload_sched_policy_listener.hload/group_commit/group_commit_mgr.hload/group_commit/wal/wal_manager.hload/group_commit/wal/wal_table.hruntime/query_context.hruntime/workload_management/workload_sched_policy_mgr.hservice/http/action/check_encryption_action.hservice/http/action/compaction_score_action.hservice/http/http_handler_with_auth.hCPP files - added full include:
agent/workload_sched_policy_listener.cppload/group_commit/wal/wal_table.cppruntime/workload_management/workload_sched_policy_mgr.cppservice/http/action/compaction_score_action.cppservice/http/http_handler_with_auth.cppTest plan
🤖 Generated with Claude Code