Skip to content

[cleanup](build) Replace #include exec_env.h with forward declaration in 19 headers #61582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuke987 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −19
Open

[cleanup](build) Replace #include exec_env.h with forward declaration in 19 headers #61582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions be/src/agent/workload_sched_policy_listener.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include "agent/workload_sched_policy_listener.h"

#include "runtime/exec_env.h"
#include "runtime/workload_management/workload_action.h"
#include "runtime/workload_management/workload_condition.h"
#include "runtime/workload_management/workload_sched_policy.h"
Expand Down
2 changes: 1 addition & 1 deletion be/src/agent/workload_sched_policy_listener.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
#include <glog/logging.h>

#include "agent/topic_listener.h"
#include "runtime/exec_env.h"

namespace doris {
class ExecEnv;

class WorkloadschedPolicyListener : public TopicListener {
public:
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/operator/aggregation_sink_operator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <stdint.h>

#include "exec/operator/operator.h"
#include "runtime/exec_env.h"
#include "runtime/runtime_profile.h"

namespace doris {
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/scan/scanner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

#include "common/status.h"
#include "core/block/block.h"
#include "runtime/exec_env.h"
#include "runtime/runtime_state.h"
#include "storage/tablet/tablet.h"
#include "util/stopwatch.hpp"
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/sink/load_stream_map_pool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
#include "core/data_type/data_type.h"
#include "exec/sink/load_stream_stub.h"
#include "exprs/vexpr_fwd.h"
#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/runtime_profile.h"
#include "runtime/thread_context.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/sink/load_stream_stub.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
#include "core/column/column.h"
#include "core/data_type/data_type.h"
#include "exprs/vexpr_fwd.h"
#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/runtime_profile.h"
#include "runtime/thread_context.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/sink/writer/vtablet_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
#include "exec/sink/vtablet_finder.h"
#include "exec/sink/writer/async_result_writer.h"
#include "exprs/vexpr_fwd.h"
#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/runtime_profile.h"
#include "runtime/thread_context.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/exec/sink/writer/vtablet_writer_v2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
#include "exec/sink/vrow_distribution.h"
#include "exec/sink/writer/async_result_writer.h"
#include "exprs/vexpr_fwd.h"
#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/runtime_profile.h"
#include "runtime/thread_context.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/load/group_commit/group_commit_mgr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "core/block/block.h"
#include "exec/sink/writer/vwal_writer.h"
#include "load/group_commit/wal/wal_manager.h"
#include "runtime/exec_env.h"
#include "util/threadpool.h"

namespace doris {
Expand Down
1 change: 0 additions & 1 deletion be/src/load/group_commit/wal/wal_info.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
// specific language governing permissions and limitations
// under the License.
#pragma once
#include "runtime/exec_env.h"

namespace doris {
class WalInfo {
Expand Down
2 changes: 1 addition & 1 deletion be/src/load/group_commit/wal/wal_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
#include "load/group_commit/wal/wal_table.h"
#include "load/group_commit/wal/wal_writer.h"
#include "load/stream_load/stream_load_context.h"
#include "runtime/exec_env.h"
#include "util/thread.h"
#include "util/threadpool.h"

namespace doris {
class ExecEnv;
class WalManager {
ENABLE_FACTORY_CREATOR(WalManager);
struct ScanWalInfo {
Expand Down
1 change: 1 addition & 0 deletions be/src/load/group_commit/wal/wal_table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "service/http/http_common.h"
#include "service/http/http_headers.h"
#include "service/http/utils.h"
#include "runtime/exec_env.h"
#include "util/client_cache.h"
#include "util/path_util.h"
#include "util/thrift_rpc_helper.h"
Expand Down
2 changes: 1 addition & 1 deletion be/src/load/group_commit/wal/wal_table.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
#include "common/status.h"
#include "load/group_commit/wal/wal_info.h"
#include "load/stream_load/stream_load_context.h"
#include "runtime/exec_env.h"
#include "service/http/action/http_stream.h"

namespace doris {
class ExecEnv;
class WalTable {
public:
WalTable(ExecEnv* exec_env, int64_t db_id, int64_t table_id);
Expand Down
2 changes: 1 addition & 1 deletion be/src/runtime/query_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "common/status.h"
#include "exec/runtime_filter/runtime_filter_mgr.h"
#include "exec/scan/scanner_scheduler.h"
#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker_limiter.h"
#include "runtime/runtime_predicate.h"
#include "runtime/workload_group/workload_group.h"
Expand All @@ -44,6 +43,7 @@
#include "util/threadpool.h"

namespace doris {
class ExecEnv;

class PipelineFragmentContext;
class PipelineTask;
Expand Down
1 change: 1 addition & 0 deletions be/src/runtime/workload_management/workload_sched_policy_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <memory>

#include "common/config.h"
#include "runtime/exec_env.h"
#include "runtime/fragment_mgr.h"
#include "runtime/workload_management/resource_context.h"

Expand Down
3 changes: 2 additions & 1 deletion be/src/runtime/workload_management/workload_sched_policy_mgr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@

#pragma once

#include "runtime/exec_env.h"
#include "runtime/workload_management/workload_sched_policy.h"
#include "util/countdown_latch.h"

namespace doris {
class ExecEnv;
class Thread;

class WorkloadSchedPolicyMgr {
public:
Expand Down
2 changes: 1 addition & 1 deletion be/src/service/http/action/check_encryption_action.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
#include <gen_cpp/FrontendService_types.h>

#include "cloud/cloud_tablet_mgr.h"
#include "runtime/exec_env.h"
#include "service/http/http_handler_with_auth.h"
#include "service/http/http_request.h"
#include "storage/tablet/tablet_manager.h"
namespace doris {
class ExecEnv;

class CheckEncryptionAction : public HttpHandlerWithAuth {
public:
Expand Down
1 change: 1 addition & 0 deletions be/src/service/http/action/compaction_score_action.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include "cloud/cloud_tablet_mgr.h"
#include "cloud/config.h"
#include "common/status.h"
#include "runtime/exec_env.h"
#include "service/http/http_channel.h"
#include "service/http/http_handler_with_auth.h"
#include "service/http/http_headers.h"
Expand Down
2 changes: 1 addition & 1 deletion be/src/service/http/action/compaction_score_action.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@

#include "cloud/cloud_tablet_mgr.h"
#include "common/status.h"
#include "runtime/exec_env.h"
#include "service/http/http_handler_with_auth.h"
#include "service/http/http_request.h"
#include "storage/storage_engine.h"
namespace doris {
class ExecEnv;

struct CompactionScoreResult {
int64_t tablet_id;
Expand Down
1 change: 1 addition & 0 deletions be/src/service/http/http_handler_with_auth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include <gen_cpp/HeartbeatService_types.h>

#include "runtime/exec_env.h"
#include "service/http/http_channel.h"
#include "service/http/utils.h"
#include "util/client_cache.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/service/http/http_handler_with_auth.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#include <gen_cpp/FrontendService.h>

#include "runtime/exec_env.h"
#include "service/http/http_handler.h"

namespace doris {
Expand Down
1 change: 0 additions & 1 deletion be/src/storage/metadata_adder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <bvar/bvar.h>
#include <stdint.h>

#include "runtime/exec_env.h"
#include "runtime/memory/mem_tracker_limiter.h"
#include "runtime/runtime_profile.h"

Expand Down
1 change: 0 additions & 1 deletion be/src/storage/rowset/rowset_writer_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "io/fs/file_system.h"
#include "io/fs/file_writer.h"
#include "io/fs/packed_file_system.h"
#include "runtime/exec_env.h"
#include "storage/olap_define.h"
#include "storage/partial_update_info.h"
#include "storage/storage_policy.h"
Expand Down
1 change: 0 additions & 1 deletion be/src/storage/segment/page_handle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#pragma once

#include "runtime/exec_env.h"
#include "storage/cache/page_cache.h"
#include "util/slice.h" // for Slice

Expand Down
Loading