[metrics] Fix pendingRecords metric to return actual row count for primary key tables when lake tiering hasn't started#3059
Open
beryllw wants to merge 1 commit intoapache:mainfrom
Open
Conversation
beryllw
force-pushed
the
fix_pendingRecords
branch
from
e074701 to
65e6504
Compare
…imary key tables when lake tiering hasn't started.
beryllw
force-pushed
the
fix_pendingRecords
branch
from
65e6504 to
33dfb54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Purpose
Linked issue: close #xxx
Fix LAKE_PENDING_RECORDS metric for primary key tables when lake tiering hasn't started yet (getLakeLogEndOffset() < 0). Previously, it returned log size (highWatermark - startOffset) which doesn't reflect actual pending records for PK tables. Now returns materialized row count for PK tables.
Brief change log
Modified registerLakeTieringMetrics() in Replica.java to use getRowCount() for primary key tables when getLakeLogEndOffset() < 0, while keeping log size calculation for non-PK tables
Tests
API and Format
Documentation