Skip to content

[metrics] Fix pendingRecords metric to return actual row count for primary key tables when lake tiering hasn't started #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beryllw wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −6
Open

[metrics] Fix pendingRecords metric to return actual row count for primary key tables when lake tiering hasn't started #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,13 @@ public class MetricNames {
// metrics for table bucket
// --------------------------------------------------------------------------------------------

// for tablet
public static final String LAKE_PENDING_RECORDS = "pendingRecords";

// for log tablet
public static final String LOG_NUM_SEGMENTS = "numSegments";
public static final String LOG_END_OFFSET = "endOffset";
public static final String REMOTE_LOG_SIZE = "size";
public static final String LOG_LAKE_PENDING_RECORDS = "pendingRecords";
public static final String LOG_LAKE_TIMESTAMP_LAG = "timestampLag";

// for logic storage
Expand Down
12 changes: 7 additions & 5 deletions fluss-server/src/main/java/org/apache/fluss/server/replica/Replica.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,11 +549,13 @@ private void onBecomeNewLeader() {
private void registerLakeTieringMetrics() {
lakeTieringMetricGroup = bucketMetricGroup.addGroup("lakeTiering");
lakeTieringMetricGroup.gauge(
MetricNames.LOG_LAKE_PENDING_RECORDS,
() ->
getLakeLogEndOffset() < 0L
? getLogHighWatermark() - getLogStartOffset()
: getLogHighWatermark() - getLakeLogEndOffset());
MetricNames.LAKE_PENDING_RECORDS,
() -> {
long lakeLogEndOffset = getLakeLogEndOffset();
return lakeLogEndOffset < 0L
? getRowCount()
: getLogHighWatermark() - lakeLogEndOffset;
});
lakeTieringMetricGroup.gauge(
MetricNames.LOG_LAKE_TIMESTAMP_LAG,
() ->
Expand Down
Loading