Add CodeQL query to check allocations do not exceed ensure_free#2101
Open
pguyot wants to merge 1 commit intoatomvm:mainfrom
Open
Add CodeQL query to check allocations do not exceed ensure_free#2101pguyot wants to merge 1 commit intoatomvm:mainfrom
pguyot wants to merge 1 commit intoatomvm:mainfrom
Conversation
pguyot
force-pushed
the
w07/add-codeql-ensure-free-size
branch
from
eaf5720 to
3b69c44
Compare
The query also checks redundant ensure_free calls, i.e. calls followed by another call with no allocation in between. Fix errors found by the query: - Fix an insufficient ensure_free in `enif_make_resource_binary` - Added a missing ensure_free in esp32 `dac_driver.c` - Remove nine redundant ensure_free calls followed by `enif_make_resource` in `otp_ssl.c` and `otp_socket.c` and esp32 drivers - Remove a redundant ensure_free call in `nif_erlang_fun_to_list` Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w07/add-codeql-ensure-free-size
branch
from
3b69c44 to
6e79c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #2100
The query also checks redundant ensure_free calls, i.e. calls
followed by another call with no allocation in between.
Fix errors found by the query:
enif_make_resource_binarydac_driver.cenif_make_resourcein
otp_ssl.candotp_socket.cand esp32 driversnif_erlang_fun_to_listThese changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later